Do not allow guest users to buy subscriptions with WooPay Direct Checkout #9792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alefesouza
requested review from
a team and
hsingyuc
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
alefesouza
changed the title
alefesouza
force-pushed
the
fix/woopay-direct-checkout-guest-subscriptions
branch
from
8667c9e to
2626806
Compare
alefesouza
commented
Nov 29, 2024
| @@ -196,6 +196,9 @@ public function ajax_get_shipping_options() { | |||
| public function ajax_get_cart_details() { | |||
| check_ajax_referer( 'wcpay-get-cart-details', 'security' ); | |||
|
|
|||
| // Process added gift cards. | |||
| add_filter( 'woocommerce_gc_disable_ui', '__return_false' ); | |||
There was a problem hiding this comment.
While working on #9846 I noticed the express checkout buttons (Apple/Google Pay) were not getting hidden on classic checkout when the cart total get to 0 by adding gift cards, as the PR was closed I'm taking the opportunity of this PR to add this line and fix that.
There was a problem hiding this comment.
Can you provide test instructions?
There was a problem hiding this comment.
@hsingyuc Testing instructions:
- Install Gift Cards.
- Create new Gift Card codes.
- Expose your site with Jurassic Tube or ngrok to enable Google/Apple Pay buttons.
- Add products to the cart.
- Access the classic checkout page.
- Add gift card codes until the total cart value reach 0.
- The Google/Apple Pay buttons should be hidden.
hsingyuc
reviewed
Dec 11, 2024
| @@ -196,6 +196,9 @@ public function ajax_get_shipping_options() { | |||
| public function ajax_get_cart_details() { | |||
| check_ajax_referer( 'wcpay-get-cart-details', 'security' ); | |||
|
|
|||
| // Process added gift cards. | |||
| add_filter( 'woocommerce_gc_disable_ui', '__return_false' ); | |||
There was a problem hiding this comment.
Can you provide test instructions?
includes/class-wc-payments.php
Outdated
| if ( ! self::$woopay_util->should_enable_woopay_on_cart_or_checkout() ) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
The code makes sense to me but I still can not reproduce the issue. Can you check my recording and see if anything I missed? Thank you!
Screen.Recording.2024-12-11.at.12.27.43.PM.mov
|
@alefesouza I can reproduce the issue if not in incognito. I'll approve this PR after testing Screen.Recording.2024-12-11.at.12.42.33.PM.mov |
|
@alefesouza could you double check with your PR, can you still use direct checkout on simple product(not subscription)? Screen.Recording.2024-12-11.at.1.03.54.PM.mov |
hsingyuc
reviewed
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9791
Changes proposed in this Pull Request
This PR fixes guest users being able to buy subscriptions using WooPay via Direct Checkout.
Testing instructions
Proceed to Checkoutbutton.Proceed to checkoutbutton.Proceed to Checkoutbutton.Proceed to checkoutbutton.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge