-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WooPay theme checkbox copy in settings page #9843
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: +62 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this, @malithsen! Code LGTM and tests as expected. The learn more link links to Checkout appearance
Could we please add a Beta badge next to "Enable global theme support" as a new enhancement as we slow roll this out and expect there to be learnings? Also could you confirm that for now it is not pre-checked for any merchant? |
@pierorocca Do we have a design for this? I can create a new PR as this one is merged.
It's not pre-checked for any merchant unless we explicitly turn on the feature via their Blog RC. |
Got it. At some point until this is all hardened and we have good data that it works in most scenarios, even if there's a feature flag in place, the safer option is to have the merchant opt-in.
I will get you this. We'd use the standard badge component used in wp-admin but I think the color would be Black instead of green, yellow, or red based on what I'm seeing used in Blocks FSE to denote a beta feature. |
Fixes #9738
Changes proposed in this Pull Request
Before
After
Testing instructions
true
in this functionnpm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge