Prevent browser error on dispute evidence submission #9847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +20 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
I did a manual test and continued seeing the popup 
|
thanks @nagpai, that's unfortunate but no unexpected. I've refactored the change to work in all cases. Additionally I found that saving draft evidence still had the popup so I've added a fix for that as well. |
jessy-p
approved these changes
Dec 2, 2024
brucealdridge
deleted the
fix/9830-browser-error-on-dispute-submission
branch
jaclync
added a commit
that referenced
this pull request
Dec 3, 2024
* develop: Remove payout timing notice and update the help tooltip. (#9812) Fix styling on payment details page in mobile view. (#9790) Prevent browser error on dispute evidence submission (#9847) Update inquiry order notes to use inquiry specific content (#9828) Restrict Stripe Link to credit card payment method and improve cleanup (#9822)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9830
Changes proposed in this Pull Request
Successful dispute evidence submission causes the browser to navigate to refresh the page. This was triggering the browser alert due to a hook on
onbeforeunload.This change ensures the evidence is reset before attempting to navigate away which prevents the browser alert.
It looks like this bug may have been introduced in #4458 when the browser navigation was introduced due to caching issues.
I chatted with @Jinksi about the best way to approach this change as there are a few improvements that could be made. For now, we agreed that the one-line fix approach is best. p1732845547215289-slack-C02BW3Z8SHK
Update: The one line fix did not work in all cases due to the way that react batches state updates async. This PR has been updated to handle this case and support both Submission and Saving of evidence.
Testing instructions
npm run changelogto add a changelog file.Post merge