Fix error log messages incorrecty categorized as info #9890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
|
When I did a manual test with the steps shared by you, I checked I tried this on my local setup, as well as Pressable test site ( with JP beta + WooPayments checked into this branch ) .
|
shendy-a8c
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
Same with @nagpai, I have a hard time confirming the change following the testing instruction.
However, I run this on WP Console both on base branch and PR branch and I can confirm the expected result.
\WCPay\Logger::log( 'something', 'error' );
Might be because my local wcpay server setup is broken (context p1733466302429219/1733402031.658199-slack-CGGCLBN58). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9889
Changes proposed in this Pull Request
Calls to
Logger::log_error()were being incorrectly labelled asinfoThis PR passes the log level categorization onto the WooCommerce logger.
Testing instructions
Force the WCPay plugin to act as disconnected from the WCPay Serverand save settings.errorlevel logs.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge