-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add failure reason to failed timeline events #9980
Add failure reason to failed timeline events #9980
Conversation
…more-info-on-transaction-details-page
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: +243 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me from the code point of view. I've tried to create a scenario when payment fails, but in my case fails are reported on the checkout form and do not create transactions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise, everything looks good. I did some testing with the hardcoded values and paths and everything works fine.
…more-info-on-transaction-details-page
…more-info-on-transaction-details-page
Fixes #5713
Changes proposed in this Pull Request
This pull request includes changes to enhance the handling of payment failure events in the payment details timeline
client/payment-details/timeline
. The most important changes include adding a new mapping for payment failure reasons, updating the timeline item formatting for failed payments, and adding new tests to cover different failure scenarios.The mappings are based on Stripe's error codes: https://docs.stripe.com/error-codes
Screenshot for reference:
Testing instructions
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge