-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide transaction fee on admin order view screen when transaction is not captured #9997
Hide transaction fee on admin order view screen when transaction is not captured #9997
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me and manual tests work as expected 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #9418
Changes proposed in this Pull Request
This small PR hides transaction fees on the admin order view screen when the charge or transaction is not yet captured.
Testing Instructions
Set WooPayments to "Issue an authorization on checkout, and capture later."
Switch to the
develop
branch.Add an item to the cart and process the payment on the checkout page.
Go to the order's view screen in the WP Admin page and confirm that the transaction fee is displayed as shown below:

Switch to this branch.
Repeat the steps above.
On the order's view screen in WP Admin, notice that the transaction fee is no longer displayed since the transaction is not yet captured.
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge