Metadata: Allow all metadata to be returned for an object #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While testing some code that was setting post metadata, I was debugging it by outputting all the metadata for a post with a call to `get_post_meta( $post_id )`. I noticed that the tests started passing but I was still getting an empty array from the `get_post_meta` call. Getting a specific key was working, which led me to look at the Metadata code here, which currently doesn't deal with the case of the key being an empty value. This change refactors the `get` function, but is probably not optimal, as we change the shape of the object's metadata using `array_reduce` on each call. It illustrates the issue, and I'm happy to optimise it if we want to go this route.
|
Thanks for this! I think it's fine if things are not super performant, This is meant to run test suites so a little bit of overload is accepted (as we are removing a lot of overload by not having a database!). Do you think you could write some tests for this? And then, from there, we can look at the best implementation |
leogermani
reviewed
Mar 27, 2023
| $obj_meta = array_reduce( | ||
| $this->meta[ $object_id ], | ||
| function ( $all_meta, $meta ) { | ||
| $all_meta[ $meta['meta_key' ] ] = array_merge( $all_meta[ $meta['meta_key'] ] ?? [], [ $meta['meta_value'] ] ); |
There was a problem hiding this comment.
I think we should keep 5.6 compatibility while core keeps it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing some code that was setting post metadata, I was debugging
it by outputting all the metadata for a post with a call to
get_post_meta( $post_id ). I noticed that the tests started passingbut I was still getting an empty array from the
get_post_metacall.Getting a specific key was working, which led me to look at the Metadata
code here, which currently doesn't deal with the case of the key being
an empty value.
This change refactors the
getfunction, but is probably not optimal,as we change the shape of the object's metadata using
array_reduceoneach call. It illustrates the issue, and I'm happy to optimise it if we
want to go this route.