Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fediverse Creator - limited options and incorrect syntax #884

Open
edent opened this issue Sep 9, 2024 · 7 comments
Open

Fediverse Creator - limited options and incorrect syntax #884

edent opened this issue Sep 9, 2024 · 7 comments
Labels
Needs triage [Type] Bug Something isn't working

Comments

@edent
Copy link
Contributor

edent commented Sep 9, 2024

Quick summary

The new plugin adds:

<meta property="fediverse:creator" name="fediverse:creator" content="blog@shkspr.mobi" />

As per the specification, the "property" isn't needed. The example given is:

<meta name="fediverse:creator" content="@Gargron@mastodon.social" />

Not all users will have their blog's name as their primary AP name. For example, I use my Mastodon handle. Perhaps this should be user selectable?

Incidentally, the meta element doesn't need a closing /

Steps to reproduce

  1. Enable the plugin
  2. View source.

What you expected to happen

  • Let the user set the creator name.
  • Use the correct syntax

What actually happened

Syntax is slightly incorrect causing minor psychic distress to nerds like me!

Impact

All

Available workarounds?

No but the platform is still usable

Logs or notes

No response

@edent edent added [Type] Bug Something isn't working Needs triage labels Sep 9, 2024
edent added a commit to edent/wordpress-activitypub that referenced this issue Sep 9, 2024
@edent edent mentioned this issue Sep 9, 2024
1 task
@pfefferle
Copy link
Member

pfefferle commented Sep 9, 2024

Hey @edent 👋

thanks for your feedback.

Incidentally, the meta element doesn't need a closing /

Yes, it does not have to be self-closing, but if you want to be XHTML compatible, you should add it. Besides of that, it is the default way WordPress handles metas and links.

As per the specification, the "property" isn't needed. The example given is:

The problem here is, that it is not an OGP extension if it has no property, so I decided to add both. It should not break anything and might be ready for possible changes that might come in next versions to be fully OGP compatible. Mastodon also supports the property attribute btw.

@edent
Copy link
Contributor Author

edent commented Sep 9, 2024

OGP is dead - https://shkspr.mobi/blog/2022/11/is-open-graph-protocol-dead/ - there won't be any more updates to it.

But fair enough on the XHTML point - if indeed there are still people using that.

@mikka2061
Copy link

In addition, the meta should open with a trailing @ sign, if I am not mistaken. Currently, mine shows

<meta property="fediverse:creator" name="fediverse:creator" content="mikka@mikka.is" />

when the proper syntax should be

<meta property="fediverse:creator" name="fediverse:creator" content="@mikka@mikka.is" />

@pfefferle
Copy link
Member

pfefferle commented Sep 10, 2024

@mikka2061 it works with and without it:

It will work with and without the leading at-symbol for the handle. If multiple tags are present on the page, the first one will be displayed, but we may add support for showing multiple authors in the future.

https://blog.joinmastodon.org/2024/07/highlighting-journalism-on-mastodon/

@mikka2061
Copy link

mikka2061 commented Sep 11, 2024

@pfefferle

https://blog.joinmastodon.org/2024/07/highlighting-journalism-on-mastodon/

That's however sadly a function of the Outlookification of the Fediverse by Mastodon. The *fish/*key Implementation (no idea how others will handle it, I presume it'll be "Mastodon forced our hand") which predates Mastodon uses const usernameServerRegex = /@[\w.-]+@ for this. I'll put in a PR for some of the fish-clones to acquiesce to Gargron, but since it's neither hair nor hide, maybe add the @ in the Plugin?

Edit: probably shouldn't say "predate" since the feature is/was in Alpha/Beta on Mastodon. I do stand by my "Outlookification" comment, since Gargron's decision to make the @ optional means a sharp turn away from the commonly used @ prefix to mean social usernames as opposed to email addresses, etc.

@pfefferle
Copy link
Member

pfefferle commented Sep 11, 2024

But the @ is something that came up with Twitter and was adopted by Mastodon, so it is mainly a UI driven thing, the pure WebFinger ID is without the @, so it is always harder to handle the @webfinger over the pure webfinger handle. That's why I technically prefer the @-less version and because this is not user facing, I am not sure if it will ever break something!?!

@mikka2061
Copy link

Ah, you're absolutely right. I stand corrected. (I'd argue, that @ predates Twitter from those IRC days of yore, I wonder if Wusel knows more about that, but you're nevertheless correct). Sending PRs out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs triage [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants