-
Notifications
You must be signed in to change notification settings - Fork 83
Move: support same-server domain migrations #1530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
7610860
first pass from AI generation. Needs work
mattwiebe 5cd4a8f
reign in the chaos
mattwiebe 9cc6984
move logic into models
mattwiebe 69f2ef9
Move constructor to below properties
obenland 7620f65
Update function name
obenland 6e9d2dd
Don't show `movedTo` on the same ID
mattwiebe 5abb3d8
DRY old domain handling
mattwiebe 9ad98a0
Add options to delete list on uninstall
obenland 83358b6
Register user option
obenland 35a34c1
Move actor saving inline
obenland b482332
changelog
mattwiebe 2073be7
Remove all followers on `Move` to allow the new Actor to be re-followed
mattwiebe 1f2693f
lint lol
mattwiebe 8c87b74
Fix indent after merge
obenland 4fc635e
Combine conditional on host
obenland 61d658b
Fix unit test
obenland 519fdc4
First pass at testing change_domain
obenland 2e707d6
Revert "lint lol"
obenland a733aca
Revert "Remove all followers on `Move` to allow the new Actor to be r…
obenland 698e2ac
Encapsulate domain check
obenland 548b5a4
Remove unused defaults
obenland 4331fb3
Hook in with feature flag
obenland 6b79395
Merge branch 'trunk' into add/same-server-domain-move
pfefferle 4106241
Add filters and handle username in callback
obenland bb40a10
Remove unused import
obenland eaee854
Add unit tests for old actors
obenland d51333d
Update reason for pre_update_option hook.
obenland 840a673
Instantiate old actors through filters
obenland b2a2aab
Remove unused import
obenland 3864e42
Merge branch 'trunk' into add/same-server-domain-move
obenland 565f515
use query instead of Http client
pfefferle 349588c
store check
pfefferle f4da950
simplify code
pfefferle d4a9141
call action before sending an Activity to inboxes
pfefferle 12de169
check class attribute before generation an id
pfefferle 111fd90
make old domain request setable
pfefferle 9d08ee5
Merge branch 'trunk' into add/same-server-domain-move
pfefferle c2310ab
Merge branch 'trunk' into add/same-server-domain-move
obenland 7650730
Account for old domain in two more places
obenland 0367cb0
Fix json creation on update_option_home
obenland 8590532
Fix tests
obenland 11482d3
Merge branch 'trunk' into add/same-server-domain-move
pfefferle c2837b4
fix phpcs
pfefferle 7372f23
use \WP_Error
pfefferle 6d627bc
Domain -> Host
obenland 17ec4e0
Merge branch 'trunk' into add/same-server-domain-move
pfefferle 02681cc
global namespace
pfefferle 90cd85a
replace `get_collection` with `get_all`
pfefferle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: major | ||
| Type: added | ||
|
|
||
| Support same-server domain migrations ⏩ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@obenland I know that you are not a fan of constants, but this would be the third possibility to enable a feature, aside from advanced settings and constants.
I think we should have a certain level of consistency. I am not arguing for a constant her, maybe we should think about a
Developer PrevieworBeta Featuressection in the Advanced settings to enable beta features!?!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be happy to deprecate feature constants in favor of filters or advanced settings