-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for The Events Calendar #860
base: trunk
Are you sure you want to change the base?
Add support for The Events Calendar #860
Conversation
Oh, this is awesome! What about enabling Events by default?
|
Is this already ready to merge? Can you give some advise how to test it properly? |
I think it is not ready for merge. I had not time for test it deeply.
Did you know if Mastoden is good for testing Events? Or did you know an other service. |
I will convert it to a draft, if you think the PR is ready, please click on "Ready for review" :) Maybe @Menrath can help with Events!?! |
@danielhuesken We are also working on supporting various Event plugins. We are also automatically enabling the support for the events post type when our plugin is activated. That seems reasonable, when somebody installs our plugin (though it took us quite some time to do so). We also added admin notifications on several pages if it's not the case. We are currently in contact with more than 10 event organizers we are evaluating our work with, and from what information I'd already gathered, automatically enabling certain post types for ActivityPub should not be done, without proper admin notification, I will write a blog post about this soon. You transformer class looks good to me, actually more advanced that ours, but ours also a WIP! We are currently working on some common settings for event post types transformation: e.g., a custom HTML summary with is composed by the events meta-data, and another example: a WordPress category to Event-Category mapper (which also targets your generic I would be glad to also merge some of your improvements in our project. We plan to release our plugin in November. @pfefferle In the end it's your decision whether to merge this into this plugin. My opinion is that this part of the code would be best at home directly at the Events Calendar Codebase. The ActivityPub Plugin providing a FrameWork for applying this seems enough for me, or those integrations should be enabled only by an extra setting. |
40bdcb3
to
3707559
Compare
@Menrath Hello, thanks for you feedback. I only wirte the code to see how it works and I have a small project where The Events Calendar plugin is used, but currently not planned to use Activitypub. So from my side takeover from the code what you would like and maybe in future i will use your plugin ;) |
This PR adds a transformer for The Events Calendar Plugin.
So event activity will be implemented for that post type.