Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip rust-cache step from GitHub Action Swift pipeline #305

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

crazytonyli
Copy link
Contributor

@crazytonyli crazytonyli commented Sep 11, 2024

The Swift part of the GitHub actions fails due to no disk space. The issue went away after I removed the rust-cache step. It seems rust-cache is not optimized for taking less disk space: Swatinem/rust-cache#158.

The Swift pipeline with and without rust-cache both take about 22m to complete. The kotline pipeline with rust-cache runs faster though.

Based on that, this PR disables rust-cache only for the Swift pipeline.

@crazytonyli crazytonyli changed the title Call lipo via xcrun Remove rust-cache step from GitHub Action pipeline Sep 12, 2024
@crazytonyli crazytonyli marked this pull request as ready for review September 12, 2024 01:12
@crazytonyli crazytonyli changed the title Remove rust-cache step from GitHub Action pipeline Skip rust-cache step from GitHub Action Swift pipeline Sep 12, 2024
Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this would result in such a huge cache, but sure – seems like a good fix

@jkmassel jkmassel merged commit febe123 into trunk Sep 12, 2024
22 checks passed
@jkmassel jkmassel deleted the github-macos-image-fix branch September 12, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants