Extract Kotlin changes from Add Login Spec PR
#655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzkocer
force-pushed
the
add-login-spec-kotlin-changes
branch
from
0a0e3b7 to
ce218c9
Compare
jkmassel
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the Kotlin and (tiny) Rust changes from #532 and adds some minor improvements/fixes on top of it. The first commit is the extraction and it mostly keeps things as is from #532 except addressing a merge conflict due to the changes from #652.
The only major change/fix is in 4c55721 which introduces
WpHttpClient. In the original PR, the request executor accepts anOkHttpClientas an argument, but then if an allowed host is added, it modifies it. This can result in unexpected behavior. In this commit, I've introduced a sealed class, so the clients can either use their ownOkHttpClientand have to implement the allowed hostnames themselves or they have to use the one we implement.I also squeezed in a tiny Rust change in 9f131cb while I was double checking the behavior from this comment.