Refactor WordPress content ID types to use macros #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces wp_content_i64_id and wp_content_string_id macros to eliminate duplication across ID type implementations. This refactor reduces boilerplate code while maintaining identical functionality and type safety. Changes: - Add wp_content_macros.rs with fully-qualified type macros - Refactor PostId, MediaId, CommentId, CategoryId, TagId, PostRevisionId, UserId to use wp_content_i64_id! - Export macros in prelude for easy access - Remove duplicate implementations (17 lines per ID type → 1 line) - Add From<T> trait implementations as enhancement - Maintain exact same generated code and behavior
oguzkocer
force-pushed
the
refactor/wp-content-id-macros
branch
from
7f8d0be to
e23344c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor WordPress content ID types to use macros, eliminating duplication across
PostId,MediaId,CommentId,CategoryId,TagId,PostRevisionId, andUserId.Changes
wp_content_i64_id!andwp_content_string_id!macros with fully-qualified typesFrom<T>trait implementations as enhancement