Add Request URL to WpAppNotifier Authentication Failure Method
#873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance the `requested_with_invalid_authentication` method in the WpAppNotifier trait to include the request URL, providing better context for authentication failures. Changes: - Update WpAppNotifier trait method to accept request URL parameter - Modify generated request executor code to capture and pass URL - Update all Rust implementations across test and CLI modules - Update Kotlin EmptyAppNotifier implementation - Update Swift EmptyAppNotifier and MockAppNotifier implementations - Add NetworkRequestAccessor trait import to generated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhances the
WpAppNotifier.requested_with_invalid_authenticationmethod to include the request URL, providing better context when authentication failures occur.Why This Change?
When authentication fails, applications need to know which specific request failed and which site it was targeting. The request URL contains valuable information including:
This enables applications to provide more informative error messages and better handle authentication failures on a per-site basis.
Breaking Change
This is a breaking change to the
WpAppNotifiertrait interface. All implementations will need to be updated to accept the new parameter.