Add xcframework code signing #966
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
force-pushed
the
add/xcframework-code-signing
branch
2 times, most recently
from
e70ef6e to
3a46021
Compare
jkmassel
force-pushed
the
add/xcframework-code-signing
branch
from
3a46021 to
2d78421
Compare
crazytonyli
reviewed
Oct 16, 2025
| team_id: APPLE_TEAM_ID, | ||
| api_key: app_store_connect_api_key, | ||
| type: 'development', | ||
| certificate_id: 'Apple Development: Created via API (886NX39KP6)', |
There was a problem hiding this comment.
What do you think about using the "Apple Distribution" one instead? I feel like it's appropriate to use binaries that are signed with "Apple Distribution" on all builds, but "Apple Development" builds may not be suitable for release builds.
crazytonyli
reviewed
Oct 16, 2025
|
|
||
| # Code Signing | ||
| APPLE_TEAM_ID = 'PZYM8XX95Q' | ||
| APPLE_BUNDLE_IDENTIFIER = 'com.automattic.hostmgr' |
There was a problem hiding this comment.
If I understand it correctly, this bundle id is only for fastlane to download the certificates and things. If that's the case, can we move it into the set_up_signing lane, to avoid the potential confusion that com.automattic.hostmgr is the "bundle id" of the wordpress-rs xcframework?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds code signing to the release and debug XCFrameworks. This allows consumer projects to ensure the binary dependency hasn't been tampered with.