Use props in render method, don't pass as arguments

Automattic · Aug 14, 2018 · e40788f · e40788f
1 parent deba47a
commit e40788f
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/client/my-sites/checklist/main.jsx b/client/my-sites/checklist/main.jsx
@@ -76,8 +76,9 @@ class ChecklistMain extends PureComponent {
 		}
 	}
 
-	renderHeader( completed, displayMode ) {
-		const { translate, isNewlyCreatedSite } = this.props;
+	renderHeader() {
+		const { displayMode, isNewlyCreatedSite, tasks, translate } = this.props;
+		const completed = tasks && ! some( tasks, { completed: false } );
 
 		if ( completed ) {
 			return (
@@ -147,8 +148,7 @@ class ChecklistMain extends PureComponent {
 	}
 
 	render() {
-		const { checklistAvailable, displayMode, siteId, tasks, translate } = this.props;
-		const completed = tasks && ! some( tasks, { completed: false } );
+		const { checklistAvailable, displayMode, siteId, translate } = this.props;
 
 		let translatedTitle = translate( 'Site Checklist' );
 		let title = 'Site Checklist';
@@ -167,7 +167,7 @@ class ChecklistMain extends PureComponent {
 				{ checklistAvailable ? (
 					<Fragment>
 						{ siteId && <QuerySiteChecklist siteId={ siteId } /> }
-						{ this.renderHeader( completed, displayMode ) }
+						{ this.renderHeader() }
 						<ChecklistShow />
 					</Fragment>
 				) : (