Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: External link icon should be mirrored in RTL #103

Closed
rachelmcr opened this issue Nov 18, 2015 · 0 comments
Closed

i18n: External link icon should be mirrored in RTL #103

rachelmcr opened this issue Nov 18, 2015 · 0 comments
Assignees
Labels
Good First Issue Small, contained issues. i18n [Type] Bug When a feature is broken and / or not performing as intended

Comments

@rachelmcr
Copy link
Contributor

screen shot 2015-11-18 at 4 35 56 pm

The external link indicator should be mirrored in RTL.

The icon seems to refer to opening a new window or a new tab, or perhaps to moving forward and out at the same time.

In an RTL environment, the new window or tab would open to the left of the current window or tab, and moving forward would mean moving left. So the arrow in the icon should point left.

Pointing right in an RTL environment suggests going back, cancelling, reverting, etc.

This should be a quick fix in CSS, with .is-rtl to add a different icon, or flip the icon.

@rachelmcr rachelmcr added [Type] Bug When a feature is broken and / or not performing as intended i18n Design labels Nov 18, 2015
@lancewillett lancewillett added Good First Issue Small, contained issues. and removed Design labels Dec 4, 2015
ralder added a commit to ralder/wp-calypso that referenced this issue Jan 3, 2016
lancewillett added a commit that referenced this issue Mar 14, 2016
jsnajdr pushed a commit that referenced this issue Jan 27, 2020
test: test correctly total_comments type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Small, contained issues. i18n [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

2 participants