-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: External link icon should be mirrored in RTL #103
Labels
Good First Issue
Small, contained issues.
i18n
[Type] Bug
When a feature is broken and / or not performing as intended
Comments
ralder
added a commit
to ralder/wp-calypso
that referenced
this issue
Jan 3, 2016
lancewillett
added a commit
that referenced
this issue
Mar 14, 2016
Flip noticons in RTL layout, fixes #103
jsnajdr
pushed a commit
that referenced
this issue
Jan 27, 2020
test: test correctly total_comments type
This was referenced Aug 10, 2020
This was referenced Jun 29, 2021
This was referenced Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Good First Issue
Small, contained issues.
i18n
[Type] Bug
When a feature is broken and / or not performing as intended
The external link indicator should be mirrored in RTL.
The icon seems to refer to opening a new window or a new tab, or perhaps to moving forward and out at the same time.
In an RTL environment, the new window or tab would open to the left of the current window or tab, and moving forward would mean moving left. So the arrow in the icon should point left.
Pointing right in an RTL environment suggests going back, cancelling, reverting, etc.
This should be a quick fix in CSS, with
.is-rtl
to add a different icon, or flip the icon.The text was updated successfully, but these errors were encountered: