Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masterbar: mobile masterbar doesn't stick when scrolling #1283

Closed
gwwar opened this issue Dec 4, 2015 · 3 comments
Closed

Masterbar: mobile masterbar doesn't stick when scrolling #1283

gwwar opened this issue Dec 4, 2015 · 3 comments
Labels
Framework Navigation [Type] Bug When a feature is broken and / or not performing as intended
Milestone
Core: Iteration 17

Comments

@gwwar
Copy link
Contributor

gwwar commented Dec 4, 2015

In a small viewport, or mobile device, scrolling content also scrolls background content leading to the following behavior:

scroll

To reproduce navigate to:

  1. http://calypso.localhost:3000/stats
  2. Select a site if prompted
  3. Click on the back to your site (you want to see left pane content).
  4. Scroll down and continue to scroll until you see the behavior above.
    Expected: Header sticks. Ideally background content does not scroll.
    Actual: Background content scrolls, and the content behind the pane displays.

cc @rralian can we squeeze this into Iteration 17?
@gwwar gwwar added [Type] Bug When a feature is broken and / or not performing as intended Framework Masterbar labels Dec 4, 2015
@rralian
Copy link
Contributor

rralian commented Dec 7, 2015

cc @rralian can we squeeze this into Iteration 17?

absolutely

@rralian rralian added this to the Core: Iteration 17 milestone Dec 7, 2015
@gwwar gwwar mentioned this issue Dec 8, 2015
Closed
@rickybanister
Copy link

cc @shaunandrews I close my other report of this as a duplicate.

@folletto
Copy link
Contributor

folletto commented Dec 8, 2015

From the other thread: this might be fixed automatically once the masterbar refactoring lands, see #631.

folletto added a commit that referenced this issue Dec 16, 2015
@folletto
Fix: the bar (fixed) now doesn't scroll away on mobile
e409caf 
Fixes #1283
@folletto folletto mentioned this issue Dec 16, 2015
Merged
folletto added a commit that referenced this issue Dec 17, 2015
@folletto @mtias
Cleanup: warnings removed (PropTypes)
e40cf62 
`section` gets initially passed as `false`, then becomes a string.

Fix: hooked up Editor preload

Cleanup: null and 0 are equivalent for ">" operator.

Cleanup: made user "isRequired".

Cleanup: shorter unseen notes code

Fix whitespace

Cleanup: isActive

Cleanup: using ES6 default param

Fix: the bar (fixed) now doesn't scroll away on mobile

Fixes #1283
@snyk-bot snyk-bot mentioned this issue Aug 21, 2020
Open
@snyk-bot snyk-bot mentioned this issue Apr 22, 2021
Open
@awaisab172 awaisab172 mentioned this issue Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Framework Navigation [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
Core: Iteration 17
Development

No branches or pull requests
5 participants
@folletto @lancewillett @rralian @rickybanister @gwwar