Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notices: compact inline notices have too much contrast in certain areas #20017

Closed
davewhitley opened this issue Nov 20, 2017 · 1 comment
Closed
Labels
Accessibility (a11y) Components Design [Status] Stale [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@davewhitley
Copy link
Contributor

Steps to reproduce

  1. Starting at URL:https://wpcalypso.wordpress.com/plugins/manage/[site]

To quote @mtias in #17796

...compact-inline which has been used to seek a more subdued approach to signaling information and is likely to clash a lot more.

screen shot 2017-11-20 at 11 33 21 am

Compact notices are now very distinctive and they were not before:

screen shot 2017-11-20 at 11 30 08 am

Suggestions

We need to retain contrast of the text so that it passes WCAG.

We could remove the background and do something like:

screen shot 2017-11-20 at 11 18 46 am

This issue doesn't seem to be as simple as diverging compact inline notices and global notices. For example, this compact inline notice should retain its dark contrast style:

screen shot 2017-11-20 at 11 17 58 am

@stale
Copy link

stale bot commented Aug 17, 2018

This issue has been marked as stale and will be closed in seven days. This happened because:

  • It has been inactive in the past 9 months.
  • It isn't a project or a milestone, and hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, `[Status] Keep Open`, or `OSS Citizen`.

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Aug 17, 2018
@stale stale bot closed this as completed Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility (a11y) Components Design [Status] Stale [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant