-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizer: Simple Payments Widget does not work on WP-Admin's Appearance > Widgets interface. #25576
Comments
As far as I can see, there are two main reasons why this doesn't work:
Now, this second reason is quite a problem. |
we rely on those customizer events to handle the media library and we'll need them (in particular |
So, I'm not an expert of this kind of things, but (one of) the major pain point is that One passage I'm lost in the widget code, is how we fill the Edit Button form with the button data. |
@rodrigoi Considering that we're close to the JP deadline, I've opened a PR that (hopefully temporarily) hides the create/edit buttons in the Widgets page: Automattic/jetpack#9811 I think we shouldn't pursue the usual quick and dirty workaround here just to ship on time, but instead we should try and figure out the best way to solve this issue once and for all. |
@Copons Maybe let's get a post up asking for opinions/options. If we feel like a proper solution won't make it in time, we can try using the temp fix for this release, and aim for a proper fix on this issue for the one after. |
@gwwar I'll ask for opinions, but the JP deadline is on Tuesday, so I'd rather have this backup PR ready to be merged in the feature branch. 🙂 |
This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels. |
This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels. |
👋 Hey folks! Since this issue has been inactive for quite some time, KitKat has made the decision to close it.
If you think this issue warrants another look, here are some next steps!
Thanks for your involvement! |
The Simple Payments Widget customizer form does not load correctly on Appearance > Widgets.
The text was updated successfully, but these errors were encountered: