-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widgets: Adds Simple Payment Buttons as Widgets #9782
Conversation
8ce126f
to
1967e37
Compare
20f0b95
to
f9a214c
Compare
Override the media query and ensure that Simple Payments widgets are always displayed as a single column.
…9673) In the frontend, only show the widget if the Simple Payments shortcode is parsed successfully. In the customizer, show the widget regardless, so that it can be modified via the pencil icon.
4e68f7d
to
bdfe618
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this and I can't seem to break it!
Can't really review the code here, though, but I'd say all the children branches have been tested and reviewed thoroughly already.
…e Payments Widget Customizer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm merging this one. It was thoroughly crafted in a super tidy way and there was a call for testing in p8oabR-ey-p2.
Thanks for the great work!
* Set boilerplate for 6.3 in readme.txt * Add changelog for 6.2.1 to changelog.txt * Set boilerplate for 6.3 in to-test.md * Sync Stable tag to 6.2.1 * Add #5647 to changelog * Add #7956 to changelog * Add #9138 to changelog * Add #9573 to changelog * Add #9728 to changelog * Add #9732 to changelog * Add #9752 to changelog * Add some testing instructions * Add #9823 to changelog * Add #9780 to changelog * Add testing instructions for #9780 * Add #9525 to changelog * Add #9782 to changelog * Add #9828 to changelog
Post-release cleanup in #9863 |
Original Feature Branch: #9577
Since this is a Feature branch, it fixes a lot of things:
Depends on:
Simple Payments: adds plan support check for Jetpack and WordPress.com (Simple Payments: adds plan support check for Jetpack and WordPress.com. #9650 and D14005-code)Changes proposed in this Pull Request:
Adds support on the Customizer to add Simple Payment Buttons as Sidebar Widgets.
Also, the user can manage their Simple Payment Buttons from the Customizer with a collapsible form
The form uses the same defaults and validations used on Calypso
Testing instructions:
Pre-requisites:
then you'll need to:
The Simple Payment Customizer should list the available Payment Buttons, and the Customizer Preview should show the item selected by default. All changes should update live on the preview window and the site should only be updated upon publishing.
To create a new product, you'll need to:
The widget preview on the customizer should clear out, and display the entered values as they are typed on the form.
the form should close, and the new SP button should be added to the drop down list. The customizer preview should show the new SP button.
the form should clear and close, and the previously selected SP button should appear on the customizer preview.
To edit and existing product, you'll need to:
The form should load the product properties, and the widget preview on the customizer should show the correct product, and update the values as they are edited on the form.
the form should close, preserving the changes on the customizer preview window and the selected item on the product drop down list.
the form should clear and close, and the previously selected SP button should appear on the customizer preview.
To delete an existing product, you'll need to:
The form should load the product properties, and the widget preview on the customizer should show the correct product.
After confirming the action, the selected product should disappear from the product drop down list. The first product on the list should be selected, and the customizer preview should reflect this change.
Known Issues and pending items:
Proposed changelog entry for your changes: