Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity: collapse updates wrapper with more than X items #25707

Closed
keoshi opened this issue Jun 22, 2018 · 7 comments
Closed

Activity: collapse updates wrapper with more than X items #25707

keoshi opened this issue Jun 22, 2018 · 7 comments
Labels
Activity Log Design [Pri] Normal Schedule for the next available opportuinity. [Size] M Medium sized issue [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@keoshi
Copy link
Contributor

keoshi commented Jun 22, 2018

If a particular site has more than X updates available, we should collapse the updates wrapper to show the oldest Y and unfold them gradually.

screen shot 2018-06-22 at 12 10 01 pm

@keoshi keoshi added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Design Rewind labels Jun 22, 2018
@keoshi keoshi self-assigned this Jun 22, 2018
@keoshi
Copy link
Contributor Author

keoshi commented Jun 22, 2018

Some context first:

  • Yes, the list of things that require an update might be gigantic...
  • ...but we shouldn't shy away from telling customers to update them.
  • Above all, we want users to stay safe, so even collapsing the list might hide certain items that might break the site if they go un-updated.
  • In my solution I've added a single control to expand the list. Once it's expanded, you won't be able to collapse it again.

@MichaelArestad @eliorivero what do you think about this?

al-threats-06 copy

al-threats-06 copy 2

@MichaelArestad
Copy link
Contributor

What if we just have the very top part and make it an expandable card?

This part:

image

And then on mobile, it could be almost identical, but instead of an expandable card, it just takes the user to a new view with the list.

@keoshi
Copy link
Contributor Author

keoshi commented Jun 22, 2018

That was my first instinct too, but turning that into an expandable card means it can be collapsed back. I almost don't want it to collapse at all. Security should be what dictates what the form should be: this module isn't meant to look pretty, it's meant to tell you your site is currently (probably) not safe.

@MichaelArestad
Copy link
Contributor

Well then maybe instead of an expandable card, we add a secondary button to the left of update all that says Show all?

@keoshi
Copy link
Contributor Author

keoshi commented Jun 22, 2018

@MichaelArestad That makes a lot of sense. Let's do that!

@keoshi keoshi assigned eliorivero and unassigned keoshi Jun 25, 2018
@keoshi
Copy link
Contributor Author

keoshi commented Jun 25, 2018

@eliorivero Assigned this to you, but please confirm if you have bandwidth to tackle this now, and let's work together on it.

@roccotripaldi roccotripaldi added the [Pri] High Address as soon as possible after BLOCKER issues label Jun 25, 2018
@eliorivero
Copy link
Contributor

eliorivero commented Jun 26, 2018

Yeah, this is something I've been experimenting too and was also thinking about collapsing it so let's do it!

@roccotripaldi roccotripaldi added [Size] M Medium sized issue [Pri] Normal Schedule for the next available opportuinity. Activity Log and removed [Pri] High Address as soon as possible after BLOCKER issues Rewind labels Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Activity Log Design [Pri] Normal Schedule for the next available opportuinity. [Size] M Medium sized issue [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

5 participants