Activity Log: Tasklist restict the task list to 3 items on page load #26710
Conversation
enejb
added
[Status] Needs Review
| } = this.props; | ||
| const { translate, name, version, type, disable, linked, slug, siteSlug } = this.props; | ||
|
|
||
| let updateType = translate( 'Plugin update available' ); |
There was a problem hiding this comment.
Hi! I've found a possible matching string that has already been translated 19 times:
translate( 'Plugin update available', 'Plugin updates available' ) ES Score: 16
See 1 additional suggestion in the PR translation status page
Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).
|
|
||
| let updateType = translate( 'Plugin update available' ); | ||
| if ( 'theme' === type ) { | ||
| updateType = translate( 'Theme update available' ); |
There was a problem hiding this comment.
Hi! I've found a possible matching string that has already been translated 21 times:
translate( 'Theme update available', 'Theme updates available' ) ES Score: 13
Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).
|
Functionality-wise, this works fine 🐑
However, it seems there was a regression at some point since the line height of the items has changed and they're cramped now, and the color of the plugin name is different.
|
matticbot
removed
[Status] Needs Design Review
Implements #25707
Currently when you are on the activity log and your site shows you all the update items.
Which can be quite overwhelming.
This PR reduced them to just 3 and shows a expand Show more link. No link is shown if we have less then or equal to 3 items to update.
Before:
After:
Mobile:
To test:
Check that there are no console log errors in your dev console.
Set a site that has more then 3 items to update visit it and note that everything looks as expected.
Click on the show more link and it will show you all the items that need updating.
Note if you have less then 3 items to update that all items are shown.