Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activity Log: simplify update notices #25765

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Activity Log: simplify update notices #25765

merged 1 commit into from
Jun 27, 2018

Conversation

eliorivero
Copy link
Contributor

This PR aims to simplify the notices for plugin and theme updates in persistent notices in Activity Log:

  • removes the repeated text Update available for
  • updates colors to move up in visual hierarchy

Before

captura-de-pantalla-2018-06-25-a-las-14-38-52

After

captura de pantalla 2018-06-26 a la s 14 14 48

@eliorivero
Activity Log: simplify update notices by removing the repeated 'Updat…
7aa246e 
…e available for'. Update colors to move up in visual hierarchy.
@eliorivero eliorivero added [Type] Enhancement [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Rewind labels Jun 26, 2018
@eliorivero eliorivero self-assigned this Jun 26, 2018
@eliorivero eliorivero requested a review from keoshi June 26, 2018 17:20
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/activity-log/simplify-persistent-notices

keoshi
keoshi approved these changes Jun 27, 2018
View reviewed changes
Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks beautiful, ship it!

@eliorivero eliorivero merged commit a43b61b into master Jun 27, 2018
@eliorivero eliorivero deleted the update/activity-log/simplify-persistent-notices branch June 27, 2018 17:21
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 27, 2018
@eliorivero eliorivero mentioned this pull request Aug 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keoshi keoshi keoshi approved these changes

Assignees

@eliorivero eliorivero

Labels
Rewind [Type] Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eliorivero @matticbot @keoshi