Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens: Add status props similar to notices #3086

Closed
ebinnion opened this issue Feb 4, 2016 · 4 comments · Fixed by #3096
Closed

Tokens: Add status props similar to notices #3086

ebinnion opened this issue Feb 4, 2016 · 4 comments · Fixed by #3096

Comments

@ebinnion
Copy link
Contributor

ebinnion commented Feb 4, 2016

In this comment @rickybanister asked:

How can we do nice inline validation in the token field? Can we?

I think we can support this by using status props similar to how notices work. We could perhaps use isSuccess and isError which would allow us to change the default colors to red and green. Thoughts?

cc @mtias

@rickybanister
Copy link

I also thought we might be able to use the Tooltip component to show a validation error attached to the errant item. Not sure how that would play together with this, but worth thinking about.

@mtias
Copy link
Member

mtias commented Feb 5, 2016

Mmm, it'd help to have some visuals of how this may work to better identify where it belongs.

@ebinnion
Copy link
Contributor Author

ebinnion commented Feb 5, 2016

This is what I've put together so far in #3096.

screen shot 2016-02-04 at 5 26 01 pm

But @rickybanister's original mocks call for a bit "lighter" of a design.

add people 5

I think a combination of #3090 and #3096 might give us something similar to the look in the second mock.

@rickybanister
Copy link

Here's the design showing a validation error (we may update the design to use something more like the tooltip to display the actual error, but:

screen shot 2016-02-05 at 1 28 35 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants