-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
People: Refresh invite UI with Form components #3058
Conversation
This makes me sad because it's not as instant and slick as the 'micro' interface in the SectionHeader, but this likely makes more long-term sense. We can ship this quickly and move on, and think about implementing the design as more of a v2. I'll keep thinking about this. In the meantime there are a few things that would be nice to improve with this PR. Namely:
Nice work on providing a quick alternative @ebinnion |
I think we definitely can. Although, it may be best to break this out in a separate PR.
We now have a validation endpoint, so there shouldn't be a technical issue here. I would suggest that we add statuses, similar to how notices work, to the tags. When we combine this with the
I'll go ahead and add that.
👍
I would say that we're OK with it as that is what currently happens in wp-admin. Also, as far as I know, the invitation system currently expects that each batch of invites is for a single role. |
Looks good to 🚢 as base for future work 👍 |
People: Refresh invite UI with Form components
This PR is meant as a possible alternative to #3046.
There are potential issues with moving the form into the section header. And as we explore that in #3046, it makes sense to compare to a form on its own route.
The main benefit here is more space. This space allows us to do things such as provide explanations and labels for the fields. We could also potentially show an inline notice below the token field to provide a bit more explanation as to why a username or email didn't validate.