Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full Site Editing: prevent circular dependencies in Templates [3] #32622

Closed
vindl opened this issue Apr 26, 2019 · 1 comment · Fixed by #33207
Closed

Full Site Editing: prevent circular dependencies in Templates [3] #32622

vindl opened this issue Apr 26, 2019 · 1 comment · Fixed by #33207
Assignees
@Copons
Labels
[Goal] Full Site Editing [Type] Task
Milestone
Cylon Sprint [21-22]

Comments

@vindl
Copy link
Member

vindl commented Apr 26, 2019

See this comment for more details: #32581 (comment)
@vindl vindl changed the title Full Site Editing: prevent circular dependencies in Templates [2] Full Site Editing: prevent circular dependencies in Templates [3] May 10, 2019
@Copons Copons self-assigned this May 21, 2019
@vindl
Copy link
Member Author

vindl commented May 21, 2019

@Copons given the new data representation, what do you think about limiting wp_template_parts to depth 1? That would mean that we don't allow nesting template parts into other template parts until we see a concrete use-case. Indirectly it would also address this problem.

@Copons Copons mentioned this issue May 21, 2019
Merged
@vindl vindl added this to the Cylon Sprint [21-22] milestone Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Copons Copons

Labels
[Goal] Full Site Editing [Type] Task
Projects
None yet
Milestone
Cylon Sprint [21-22]
Development

Successfully merging a pull request may close this issue.

Full Site Editing: Template Parts can only be inserted into Templates Automattic/wp-calypso
2 participants
@vindl @Copons