Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full Site Editing: Template Parts can only be inserted into Templates #33207

Merged
merged 1 commit into from
May 24, 2019
Merged

Full Site Editing: Template Parts can only be inserted into Templates #33207

merged 1 commit into from
May 24, 2019

Conversation

Copons
Copy link
Contributor

@Copons Copons commented May 21, 2019 •
edited
Loading

Changes proposed in this Pull Request

  • To reduce the FSE scope and also to avoid infinite loops: limit the Template Part block to just the Template post type.

Practically speaking, this prevents adding a Template Part inside another Template Part, whose usefulness is debatable.

Testing instructions

  • Follow the FSE readme, and setup the plugin.
  • Create a Template, and make sure you can add Template Part blocks.
  • Create any other post type (including Template Part), and make sure you cannot add Template Part blocks.

Fixes #32622

@Copons Copons added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Full Site Editing labels May 21, 2019
@Copons Copons requested a review from a team May 21, 2019 17:17
@Copons Copons self-assigned this May 21, 2019
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/32622-fse-template-infinite-loop

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

rodrigoi
rodrigoi approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@rodrigoi rodrigoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🌕

@rodrigoi rodrigoi added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 23, 2019
@Copons Copons force-pushed the fix/32622-fse-template-infinite-loop branch from f616925 to 015d0c7 Compare May 24, 2019 11:48
@Copons Copons merged commit 4a6637d into master May 24, 2019
@Copons Copons deleted the fix/32622-fse-template-infinite-loop branch May 24, 2019 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigoi rodrigoi rodrigoi approved these changes

Assignees

@Copons Copons

Labels
[Goal] Full Site Editing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Full Site Editing: prevent circular dependencies in Templates [3]
3 participants
@Copons @matticbot @rodrigoi