Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: TinyMCE pinned toolbar improvements #337

Closed
3 tasks
kriskarkoski opened this issue Nov 20, 2015 · 2 comments · Fixed by #4824
Closed
3 tasks

Editor: TinyMCE pinned toolbar improvements #337

kriskarkoski opened this issue Nov 20, 2015 · 2 comments · Fixed by #4824
Assignees
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Pri] Normal Schedule for the next available opportuinity. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Milestone

Comments

@kriskarkoski
Copy link
Contributor

There are some potential improvements to be made regarding the inner workings of how the tinyMCE toolbar transitions from being static to becoming pinned at the top of the page.

  • Move pinned func. to a TinyMCE plugin
  • Throttle window.onscroll
  • Parameterize/calculate the top offsets (46 = master bar height, 139 = master bar height + toolbar height)

raised by aduth adambbecker

@kriskarkoski kriskarkoski added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] Normal Schedule for the next available opportuinity. labels Nov 20, 2015
@kriskarkoski kriskarkoski added this to the Editor: Next milestone Nov 20, 2015
@jeremeylduvall
Copy link
Contributor

When I scroll down on a long post, the tinyMCE toolbar sticks to the top of the window as it should. But, when I scroll up slowly, instead of stopping in the normal spot, it continues to stick to the top of the page when it shouldn't. Wonder if we could address that with the items above?

scrolling

@kriskarkoski
Copy link
Contributor Author

There's an issue specifically for this case that hasn't been moved over yet
and I believe it's specific to having a featured image set. When it's moved
I'll try to remember to cross-link it here.

On Thursday, November 26, 2015, Jeremey DuVall notifications@github.com
wrote:

When I scroll down on a long post, the tinyMCE toolbar sticks to the top
of the window as it should. But, when I scroll up slowly, instead of
stopping in the normal spot, it continues to stick to the top of the page
when it shouldn't. Wonder if we could address that with the items above?

[image: scrolling]
https://cloud.githubusercontent.com/assets/7240478/11426533/10d1b410-941a-11e5-967e-b7b9ed5e22df.gif


Reply to this email directly or view it on GitHub
#337 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Pri] Normal Schedule for the next available opportuinity. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants