Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: implement "preview" everywhere #3901

Closed
rralian opened this issue Mar 9, 2016 · 4 comments
Closed

Framework: implement "preview" everywhere #3901

rralian opened this issue Mar 9, 2016 · 4 comments

Comments

@rralian
Copy link
Contributor

rralian commented Mar 9, 2016

We have an excellent in-page preview component that we use for the editor. We should use this in other areas where it is helpful for people to preview their content. Examples include post-list, pages-list, menus, etc.

@rralian rralian added this to the Plans Iteration 0 milestone Mar 9, 2016
@mtias
Copy link
Member

mtias commented Mar 10, 2016

cc @ehg @mcsf :)

@folletto
Copy link
Contributor

A note: the component still has some bugs which I feel should be sorted before diving more into using it (#3707, #2129, #2001, #568, #312, #316, and to a lesser extent #2013, #3220).

I've also noticed that in some instances two scrollbars show up (remember to always work with visible scrollbars), and in Firefox I noticed (but I can't reproduce consistently) that with the trackpad the scrolling sometimes doesn't work until the page behind has scrolled completely.

@rralian
Copy link
Contributor Author

rralian commented Mar 22, 2016

This seems more like a goal than a concretely achievable task. I think specific integrations make more sense as trackable items. I'm removing this from the plans iteration 0 milestone for now. @mtias up to you if you want to keep this item open on its own.

@rralian rralian removed this from the Plans Iteration 0 milestone Mar 22, 2016
@mtias
Copy link
Member

mtias commented Mar 25, 2016

@rralian I've worked on #4140 adding a layoutFocus for previewing that is the general approach. Anything else we can track separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants