WebPreview: prevent scrolling when web preview is open. #3984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
added
[Status] Needs Review
| @@ -70,6 +71,10 @@ const WebPreview = React.createClass( { | |||
| if ( this.props.previewUrl !== 'about:blank' ) { | |||
| this.setIframeUrl( this.props.previewUrl ); | |||
| } | |||
|
|
|||
| if ( this.props.showPreview ) { | |||
| componentClasses( document.documentElement ).add( 'no-scroll' ); | |||
There was a problem hiding this comment.
Can we just start using classList instead?
document.documentElement.classList.add( 'no-scroll' );
|
Works as expected. Would like to see my recommended change made, but otherwise looks good 👍 |
aduth
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
Also removes extra scrollbars from body.
mtias
force-pushed
the
fix/web-preview-double-scrolls
branch
from
f7fe29a to
4380556
Compare
mtias
added
[Status] Needs Review
|
👍 |
aduth
added
[Status] Ready to Merge
and removed
[Status] Needs Review
mtias
added a commit
that referenced
this pull request
Mar 11, 2016
WebPreview: prevent scrolling when web preview is open.
This was referenced Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes extra scrollbars from body. See #3901.
Fixes #316