Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layouts: Gutenberg (+) buttons appearing in Services Layout preview #39349

Closed
ianstewart opened this issue Feb 10, 2020 · 9 comments
Closed

Layouts: Gutenberg (+) buttons appearing in Services Layout preview #39349

ianstewart opened this issue Feb 10, 2020 · 9 comments
Assignees

Comments

@ianstewart
Copy link
Contributor

Chrome and MacOS.

image

This seems particular to this layout.

@iamtakashi @alaczek

@ianstewart
Copy link
Contributor Author

Also visible in the Alves Layout …

image

@obenland
Copy link
Member

IIRC those are being hidden through CSS, so we might just need to update that selector to include these blocks

@ianstewart
Copy link
Contributor Author

Not sure if related (or potentially another issue) but …

image

… are these large gaps in the preview related to a hidden + button? (If so, I can make another issue.)

@obenland
Copy link
Member

are these large gaps in the preview related to a hidden + button?

Answered by @marekhrabe in Slack, quoted here for posterity:

[We] are rendering previews in a narrow container (that would usually trigger some smaller media queries), however the CSS media queries are computed against the whole screen which means unexpected results.

@iamtakashi
Copy link
Contributor

are these large gaps in the preview related to a hidden + button?

The large gaps seem to be mostly coming from the difference in vertical margins for blocks between the front of the site and the editor CSS in the Varia based themes.

@iamtakashi
Copy link
Contributor

The large gaps seem to be mostly coming from the difference in vertical margins for blocks between the front of the site and the editor CSS in the Varia based themes.

For example Automattic/themes#1798

@marekhrabe
Copy link
Contributor

I will tackle just the "plus" buttons in this issue. We seem to have #39355 specifically for the large gap problems.

@marekhrabe marekhrabe self-assigned this Feb 25, 2020
@marekhrabe
Copy link
Contributor

PR that should fix this WordPress/gutenberg#20433

@marekhrabe
Copy link
Contributor

Fixed. It will be shipped in next Gutenberg release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants