-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove !important override from Buttons block #20433
Remove !important override from Buttons block #20433
Conversation
Size Change: -7 B (0%) Total Size: 865 kB
ℹ️ View Unchanged
|
This looks like the Unless @jorgefilipecosta knows of anything, then it seems like removing the |
Yeah, just wondering the cause of adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 I tried this PR on the trunk branch and this still works as they should. I think important was added by mistake.
The Travis CI errors with this message:
It doesn't look related in any way but it's failing quite consistently for me. Can I still merge or should I retry until I might have a good luck? |
Hi @marekhrabe, I merged the change. |
Description
Adding the Buttons block in #17352 has broken previews because it adds
!important
to setting the appender to display it as an inline block. Previews try their best to hide UI like this but adding the!important
has prevented that from working.Is it necessary? I have briefly tested the Buttons block without
!important
and there seems to be no obvious glitch happening. However, as the usage of the!important
didn't seem to have been commented, I'm not sure what to look for and where it potentially breaks.cc: @jorgefilipecosta as the original author
How has this been tested?
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: