Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Plugins: Give a more specific error message on plugin activation/deactivation/update failures #409

Closed
v18 opened this issue Nov 22, 2015 · 0 comments
Assignees
Labels
Jetpack [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@v18
Copy link
Contributor

v18 commented Nov 22, 2015

If you try to activate a plugin that causes a fatal error, we don't currently pass that detail back from the remote site (or display it in Calypso). We indicate that the update failed, but not really why. We should ideally pass back a more descriptive reason (from the remote site), and then provide an error along the lines of what WP core does ("Plugin could not be activated because it triggered a fatal error.")

Here's a detailed example: Test on a site that requires FTP permission in order to install or update plugins. This is accomplished by setting the file permissions of wp-content to 555 (the directory itself, not necessarily the files within).

To make sure that FTP permissions are needed to install a plugin, you can try installing a plugin and get this dialog:

install-plugin-get-asked-for-ftp-deets

You can try to update a plugin and get this dialog:

update-plugin-need-ftp

When trying to update a plugin on Calypso you see an error message instead of nothing:

Step 1: Click the update link:

d96d0142-7e51-11e5-80e8-acf0f99649e8

Step 2: Calypso shows an alert that it's trying to update the plugin:

fd858f7c-7e51-11e5-81a3-bbd9cf1699bf

Step 3: see error message:

0e4bad46-7e52-11e5-9a3f-01f90c1a07d4

The error message isn't very informative.

@v18 v18 added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Jetpack Jetpack Plugins labels Nov 22, 2015
@roccotripaldi roccotripaldi self-assigned this Dec 15, 2015
@scruffian scruffian assigned enejb and unassigned roccotripaldi Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

3 participants