Plugins: Add better plugin notices to install and update errors #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enejb
added
Jetpack
[Status] Needs Review
enejb
force-pushed
the
add/improved-error-messages-install-plugins
branch
from
80f8e2c to
39bcf09
Compare
|
Works great for the cases I could test! 🚢
|
johnHackworth
added
[Status] Ready to Merge
and removed
[Status] Needs Review
| return i18n.translate( 'The update cannot be installed because we will be unable to copy some files. This is usually due to inconsistent file permissions.' ); | ||
|
|
||
| default: | ||
| return null; |
|
Looks good, thanks for picking this up Enej, and sorry I could not get to it. |
enejb
force-pushed
the
add/improved-error-messages-install-plugins
branch
from
39bcf09 to
d24c3b1
Compare
enejb
force-pushed
the
add/improved-error-messages-install-plugins
branch
from
ac546f8 to
86c873a
Compare
enejb
added a commit
that referenced
this pull request
Jan 21, 2016
…install-plugins Plugins: Add better plugin notices to install and update errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #409.
Add additional explanation As to why a plugin might have failed or updated. The explanation text currently is exactly the same that we would get from WordPress if the same error occurred. I wasn't able to test each of the cases.
cc: @johnHackworth, @roccotripaldi and @lezama