Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenboarding: the NextButton and SkipButton components throw a console warning for the isLarge props #44603

Closed
andrewserong opened this issue Aug 3, 2020 · 2 comments
Assignees
Labels
Good First Issue Small, contained issues.

Comments

@andrewserong
Copy link
Member

andrewserong commented Aug 3, 2020

The isLarge prop for the Button component was recently deprecated in Gutenberg. The current usage in Gutenboarding is throwing a console warning wherever the SkipButton and NextButton are used.

Because isLarge didn't appear to be adding any CSS to the styling of the buttons, it appears to be safe to remove these props.

Steps to reproduce

  1. Starting at URL: calypso.localhost:3000/new
  2. From the intent gathering step, the SkipButton component is throwing a warning due to the isLarge prop being present
  3. Continue to the Style step /new/style and the NextButton component is throwing a similar warning

Screenshot / Video

image

Context / Source

In Gutenboarding, we are basing the user interface in many of the components included in Gutenberg, e.g. the Button component. You can preview these components in the Gutenberg storybook (more on the Gutenberg Storybook setup).

For context, the isLarge prop was removed in: WordPress/gutenberg#23239
The NextButton and SkipButton components are defined in /packages/onboarding/src/action-buttons/index.tsx
These buttons are then used in Gutenboarding in a few places, e.g. in the intent gathering step, and the style preview.

It is appears that it should be safe to remove the isLarge props from https://github.com/automattic/wp-calypso/blob/HEAD/packages/onboarding/src/action-buttons/index.tsx#L44

@andrewserong andrewserong self-assigned this Aug 3, 2020
@andrewserong andrewserong added the Good First Issue Small, contained issues. label Aug 3, 2020
@andrewserong
Copy link
Member Author

I thought this would be a good one for @autumnfjeld to dive into :)

@andrewserong
Copy link
Member Author

Closed by @autumnfjeld in #44678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Small, contained issues.
Projects
None yet
Development

No branches or pull requests

2 participants