Gutenboarding: the NextButton and SkipButton components throw a console warning for the isLarge
props
#44603
Labels
Good First Issue
Small, contained issues.
The
isLarge
prop for the Button component was recently deprecated in Gutenberg. The current usage in Gutenboarding is throwing a console warning wherever theSkipButton
andNextButton
are used.Because
isLarge
didn't appear to be adding any CSS to the styling of the buttons, it appears to be safe to remove these props.Steps to reproduce
isLarge
prop being present/new/style
and the NextButton component is throwing a similar warningScreenshot / Video
Context / Source
In Gutenboarding, we are basing the user interface in many of the components included in Gutenberg, e.g. the Button component. You can preview these components in the Gutenberg storybook (more on the Gutenberg Storybook setup).
For context, the
isLarge
prop was removed in: WordPress/gutenberg#23239The
NextButton
andSkipButton
components are defined in /packages/onboarding/src/action-buttons/index.tsxThese buttons are then used in Gutenboarding in a few places, e.g. in the intent gathering step, and the style preview.
It is appears that it should be safe to remove the
isLarge
props from https://github.com/automattic/wp-calypso/blob/HEAD/packages/onboarding/src/action-buttons/index.tsx#L44The text was updated successfully, but these errors were encountered: