Button Component - remove isLarge prop #23239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate the component docs to remove its reference
rmorse
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
youknowriad
approved these changes
Jun 17, 2020
ZebulanStanphill
added
[Feature] UI Components
|
I see the Travis build failed on 2 things, one was the isLarge test - which I've gone ahead and removed... Do I need to do a new pull request? |
github-actions
bot
added
the
First-time Contributor
|
Congratulations on your first merged pull request, @rmorse! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
This was referenced Jun 24, 2020
Closed
aaronrobertshaw
added a commit
to Automattic/jetpack
that referenced
this pull request
Aug 3, 2020
The isLarge prop has been removed from Gutenberg Button component. Leaving the prop in place results in console error so should be removed. WordPress/gutenberg#23239
nickcernis
added a commit
to studiopress/genesis-custom-blocks
that referenced
this pull request
Aug 7, 2020
Prevents a console error in WP 5.5 caused by the attribute being removed in 5.5. See: - Removal: WordPress/gutenberg#23239 - Note about isLarge having no effect in the first place: WordPress/gutenberg#16541 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and class name + update the component docs to remove its reference - to finish the work done in - #16541
Description
The Button component was still accepting an
isLargeprop, and adding anis-largeclass to the button when it should not be - #16541How has this been tested?
We're removing a prop + class - I've test by passing
isLargeas a prop and observing that the html class is no longer added.This change should not affect other components but I have observed some tests using the isLarge prop.
Types of changes
Prevents the use of isLarge to add a class to a button - removing as soon as possible will prevent adoption of this feature.
Checklist: