Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Remove isLarge from our buttons #2922

Closed
senadir opened this issue Jul 28, 2020 · 2 comments
Closed

Remove isLarge from our buttons #2922

senadir opened this issue Jul 28, 2020 · 2 comments
Labels
type: bug The issue/PR concerns a confirmed bug.

Comments

@senadir
Copy link
Member

senadir commented Jul 28, 2020

In WP 5.5, isLarge is no longer defined as an attribute for @wordpress/components/button, it seems it served no purpose from the beginning, so we can remove it safely as it triggers a console error in 5.5
image

It triggers an error because isLarge is not destructured in Button, causing it to go along with ...additionalProps and eventually being spread into button HTML element.
@senadir senadir added the type: bug The issue/PR concerns a confirmed bug. label Jul 28, 2020
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Remove the stale label or post a comment, otherwise it will be closed in 10 days.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 12, 2020
@nerrad
Copy link
Contributor

nerrad commented Dec 15, 2020

This has been fixed so can be closed.

@nerrad nerrad closed this as completed Dec 15, 2020
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nerrad @senadir