Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isLarge prop from Button block in FSE starter-page-templates #44021

Conversation

andrewserong
Copy link
Member

In Gutenberg the isLarge prop was removed from the Button component in WordPress/gutenberg#23239 — this PR removes the prop from our instance of the Button block in starter page templates, so that it doesn't error in the console

This it the button in question — it should look the same after applying this change.

image

Changes proposed in this Pull Request

  • Remove isLarge prop from Button component
  • Add translators line to keep linting happy!

Testing instructions

You should not see the following error in the console:

image

  • Spin up a local development environment (e.g. go to the apps/full-site-editing directory and run wp-env start
  • Run the local dev environment for FSE (e.g. fo to the apps/full-site-editing directory and run yarn dev or if you want to sync to your sandbox, run yarn dev --sync)
  • In your WP install, go to create a new page, and it should open up the starter page templates page layout picker
  • The button in the top right should look and function the same as normal
  • You shouldn't see the console error about isLarge

Fixes #

@matticbot
Copy link
Contributor

@andrewserong andrewserong self-assigned this Jul 9, 2020
@andrewserong andrewserong added [Type] Bug When a feature is broken and / or not performing as intended [Type] Janitorial [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 9, 2020
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

Caution: This PR affects files in the FSE Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D46164-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2

Copy link
Contributor

@Addison-Stavlo Addison-Stavlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, smoke tested and works as expected.

@Addison-Stavlo Addison-Stavlo merged commit 39ed68c into master Jul 9, 2020
@Addison-Stavlo Addison-Stavlo deleted the fix/starter-page-templates-remove-is-large-prop-from-button-block branch July 9, 2020 14:30
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 9, 2020
@deBhal deBhal mentioned this pull request Jul 13, 2020
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug When a feature is broken and / or not performing as intended [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants