Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog Posts Block: Excerpt Word Limit Ignored for Posts with a Custom Excerpt #51415

Closed
wpericam opened this issue Mar 25, 2021 · 6 comments · Fixed by Automattic/newspack-blocks#874
Labels
[Block] Blog Posts OSS Citizen [Pri] High Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@wpericam
Copy link

wpericam commented Mar 25, 2021

Steps to reproduce the behavior

  1. Add a Blog Post Block to a page
  2. Limit the number of words in an excerpt to a certain number such as 13
  3. Edit a post and add a custom excerpt with more words than you set in the block above
  4. View the page with Blog Posts Block and notice that the full custom excerpt is shown and "read more" or "continue reading" button is missing from the post that has a custom excerpt

What I expected to happen

In the context of a Blog Post Block, on a homepage for example, it makes sense that one might want a shorter excerpt than they want to appear on their main blog posts page/feed. I would expect (as 3812805-zen did) that the Blog Post Block setting would limit both automatic and custom excerpts to the set number of words.

What actually happened

Instead, the Blog Post Block will ignore the number of words limit. The full custom excerpt is shown (and the "read more" or "continue reading" button is missing from the post that has a custom excerpt.)

@kristenzuck kristenzuck added the User Report This issue was created following a WordPress customer report label Apr 29, 2021
@mrfoxtalbot mrfoxtalbot added the Triaged To be used when issues have been triaged. label Jul 26, 2021
@mrfoxtalbot
Copy link

I can confirm that the number of characters in the excerpt setting is not working reliably.

@dpasque
Copy link
Contributor

dpasque commented Aug 6, 2021

Tagging @Automattic/flow-patrol-create based on issue content

@Gustavo-Hilario
Copy link

This issue was also reported here #4292632-zen
Theme: Awaken Pro

I was not able to reproduce this issue on a test site. Here is a screencast. In the editor, the word limit may not work, but once the page was published it worked fine.

@synora
Copy link
Contributor

synora commented Sep 15, 2021

Just noting that I'm able to replicate based on @wpericam's steps. In my test, I set the Block Posts Block "Max number of words in excerpt" setting to 10.

The first two posts in the following screenshot are using a custom excerpts. The full custom excerpt is displayed and the "Read More" button is missing from those two.

The last post, titled "Testing", isn't using a custom excerpt. The Blog Post Block's excerpt word number setting is being honored there and the "Read More" button displays as expected.

Annotation on 2021-09-15 at 09-13-45

obenland added a commit to Automattic/newspack-blocks that referenced this issue Sep 17, 2021
Trims excerpts even if it's a custom excerpt for a uniform look.

Fixes Automattic/wp-calypso#51415
adekbadek pushed a commit to Automattic/newspack-blocks that referenced this issue Sep 22, 2021
Trims excerpts even if it's a custom excerpt for a uniform look.

Fixes Automattic/wp-calypso#51415

* fix: misspelled deprecated flag

Props @mreishus.
@devNigel
Copy link

devNigel commented Sep 25, 2021

Is the fix live? I can still reproduce the issue on the site in this ticket: 4292632-zen

I'm reopening the bug report.

@devNigel devNigel reopened this Sep 25, 2021
@formosattic
Copy link

Unable to reproduce on my test site.
I've asked the user to remove the current Blog Posts and add it again.

Closing for now, but open if the problem is still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Blog Posts OSS Citizen [Pri] High Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants