-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using a File Block with a PDF makes the editor crash in Safari #53595
Comments
Ok so this one is weird. I did a few tests on an .org site and concluded that:
I noticed this error in the console (in Chrome, since Safari crashes):
I found a couple of related core issues, but I am not 100% sure they are related. |
Ok, so I have reported this here since it seems to be coming from core. The difference seems to be that in WordPress.com the bug causes Safari to break, specifically. But this is rather strange, because it is happening the exact opposite:
|
@mrfoxtalbot Apparently, this is expected behavior, isn't it? :) |
Thank you for checking, @taggon! The part about the block breaking if the plugin is deactivated IS expected, but:
Would this make sense? Do you think we could look into why the block is not loading in simple sites and why it is causing Safari to crash completely (as opposed to just showing a broken/unavailable block)?. Thank you! |
another incident of this today in 30641635-hc |
I confirmed this issue still happens in Safari only on simple sites. The block editor in Atomic sites and self-hosted sites doesn't have the problem. Given that where the problem occurs, I assume that this issue is related to dotcom version Gutenberg. Unfortunately, I don't have expertise in Gutenberg. So I unassign myself from this issue hoping a Gutenberg expert will chime in. |
Another report in https://wordpress.com/forums/topic/edit-screen-blank/?view=all, and I've confirmed an a test site it still happens. Current Safari version 15.0 |
Another report on 4626133-zen Tested on that site with Safari Version 15.1 (17612.2.9.1.20). This is the error that I'm getting (I've masked the site and file URLs):
|
Another instance here: 33646033-hc I confirmed on a test site as well. |
Another report in https://wordpress.com/forums/topic/i-cant-change-one-page-of-my-website and I can confirm that I have the same issue if I try to edit a page with a PDF embed in Safari. Safari 15.2 on Mac OS 10.15 |
I believe I encountered close to this issue today, here: 33855257-hc Safari didn't crash, but this user in Safari couldn't open either of their 2 posts that contained PDFs. The PDF settings defaulted to With the latest updates to the PDF embed (not showing inline embed on front end sites anyway), I wonder if this setting can be removed/hidden from the block altogether. |
I just found exactly what you mentioned here as well. This occurs in Safari only, all other browsers are fine. The Safari developer console showed no errors, the page just fails to load. I turned off the PDF preview so that the file is download only and then the page loads fine in Safari. |
I can't seem to reproduce this anymore. I'm wondering if the fix issued here: #52728 affected this one. Will leave this open for now in case someone else can, but I think it can be closed. |
This hasn't had any new user reports so I'm going to close it. Feel free to reopen if someone experiences this issue again. |
Support References This comment is automatically generated. Please do not edit it.
|
Steps to reproduce the behavior
What I expected to happen
What actually happened
In Chrome/Firefox, the editor will render the PDF as an embed (which sounds not ideal, IMO). In Safari, the editor will not load and show a blank page.
Chrome:
Screenshot: https://d.pr/i/S27E3C
Safari - the editor freezes completely, likely trying to render the PDF as an embed
Screenshot: https://d.pr/i/yWxmXk
Context
Seems to be related to #52743
Browser / OS version
Safari 14.1
Is this specific to the applied theme? Which one?
No
Does this happen on simple or atomic sites or both?
Only tested Simple Sites
Is there any console output or error text?
I can't get the console errors from Safari, but here are the ones from Chrome:
Level of impact (Does it block purchases? Does it affect more than just one site?)
Low
Reproducibility (Consistent, Intermittent) Leave empty for consistent.
Screenshot / Video: If applicable, add screenshots to help explain your problem.
The text was updated successfully, but these errors were encountered: