-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Block: PDFs are shown as embeds only in the editor on Simple sites #52728
Comments
Not transferring to Gutenberg as this affects Simple sites only. |
21646911-hc Pasting on its own line allowed it to embed |
I encountered this in 30237796-hc - pasting the PDF URL directly into the editor was a suitable workaround. |
I suspect this is not so much a bug, but a design gap. By default, all file blocks will show just as a link and a button. The block was "improved" to show the PDFs "preview" but no option has given to keep it as a simple file link. Ideally, I would advocate treating the PDF file as any other file and add an option in the block settings to "convert it to an embed". Would this make sense @chad1008? Thank you! |
@mrfoxtalbot I'm reopening this as the issue is not with what's shown in the editor, but rather when the inline embed option is enabled it still shows as a link and button on the front-end rather than how it looks in the editor. Perhaps we should update the title/description to make the issue more clear? |
Thank you @kriskarkoski I got that the other way around. 😬 |
@kriskarkoski, this appears to be a duplicate, right? #52992 |
@mrfoxtalbot I closed #52992 since this issue was opened first, but I do see there's a third one at #52743 also opened after. I'll leave these in your hands from here |
Thank you @msilbers! Ideally, we will want to get back to our users letting them know the issue is solved. I am adding the full list of related issues here for reference: Also, I am wondering if this might be related to #53595 @taggon, do you think there might be a connection between these two issues? Thank you! |
I have another report where the customer expected for the embed to work on the live page, but it does not. It seems like the #24043773-hc |
30262302-hc as well |
Another case in 4238984-zen |
Another report here: 4673233-zd-woothemes |
Another here: zd-4679947 |
4686073-zd-woothemes |
Another report: 33661080-hc |
Just surfacing this as it seems like it might be related to how this bug is fixed: |
Another report: 4697471-hc |
@Nic-Sevic Thanks for sharing this! For anyone here - does this mean that PDFs not displaying on live sites is now the intended design? I'm not sure if we're expecting a "solution" that allows PDFs to display again, or if this security change means that this features is going away. |
Another report: 4710700-zen I've made a comment to this related p2: p3btAN-1Ab-p2#comment-15424 |
Reported in 32784736-hc |
Another report in 33878839-hc |
Another report here: https://twitter.com/elevennames/status/1487469354769920009 |
Another report: 4734865-zd-woothemes |
Another report: 4732235-zd-woothemes |
4708055-zd-woothemes |
Another report at 4678870-zen |
4742534-zd-woothemes would like to be informed when solved |
4760061-zd-woothemes |
Another report here 29586695-hc . |
As @metabreakr points out, this issue is discussed in p3btAN-1Ab-p2. Updated initial post with workarounds to inline embed PDFs. |
33485094-hc would want to be notified once fixed |
User on the forums having this issue and would like to be notified when this is fixed: https://wordpress.com/forums/topic/problem-inserting-pdf-files/?view=all Did not suggest a workaround as they found their own (uploading to Google Drive instead). |
Closing as this seems to have been fixed as of now. Tested on themes:
|
Might need reopening, @1dr0, I ran across what seems to be another case in 31616736-hc |
Steps to reproduce the behavior
What I expected to happen
The editor should match the front end, displaying only the link and download button
What actually happened
The two views have very different results, which is confusing.
Workarounds
Other methods to inline embed PDFs:
Browser / OS version
Chrome 90.0.4430.93
Does this happen on simple or atomic sites or both?
Simple only
Screenshot / Video: If applicable, add screenshots to help explain your problem.
The text was updated successfully, but these errors were encountered: