Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE Beta: Upgrade Nudge on Cover Blocks Breaks Layout in Site Editor #59501

Closed
carinapilar opened this issue Dec 22, 2021 · 4 comments · Fixed by Automattic/jetpack#22640
Closed
Assignees
Labels
[Pri] High Address as soon as possible after BLOCKER issues [Type] Bug

Comments

@carinapilar
Copy link

carinapilar commented Dec 22, 2021

Quick summary

There's an upgrade nudge on Cover blocks shown only in the Site Editor.

Steps to reproduce

  1. Use a test site on a Free plan
  2. Activate a theme and choose to have the homepage set with its content
  3. Open the Site Editor

What you expected to happen

To see in the editor the content as it shows on the live site.

What actually happened

It shows an upgrade nudge on every Cover block you have on the page.

Context

This doesn't happen if you edit the page through the Pages menu, but this is what you get in the Site Editor:

CoverBlockUpgradeNudge

Sometimes the nudge changes the layout quite a bit, here's an example with the theme's content (with Quadrat):

CoverBlockUpgradeNudge2

@formosattic
Copy link

Looks like this is already fixed. I'm unable to reproduce.

troubleshooting

Closing, but open if it happens again.

@carinapilar
Copy link
Author

carinapilar commented Dec 28, 2021

I can still replicate this, I'm testing on a Simple free site. I followed the steps below now:

  1. I have Quadrat White now.
  2. Created a new page with a Cover block.
  3. Set that new page as the site's homepage.
  4. Open the Site Editor from Appearance.

And this is what I get:

CoverNudge

@carinapilar carinapilar reopened this Dec 28, 2021
@formosattic formosattic added the [Pri] Normal Schedule for the next available opportuinity. label Dec 28, 2021
@formosattic
Copy link

formosattic commented Dec 28, 2021

Thanks @carinapilar!

I removed the Premium plan on my test site, and was able to see all the upsell nudges.

I updated the steps in the initial post to include the "Free plan" requirement.

@ianstewart ianstewart changed the title FSE Beta: Upgrade Nudge on Cover Blocks FSE Beta: Upgrade Nudge on Cover Blocks Breaks Layout in Site Editor Jan 27, 2022
@simison
Copy link
Member

simison commented Jan 28, 2022

Happening with "Blank" option when creating a new FSE site via https://horizon.wordpress.com/start/domains

image

@ianstewart ianstewart added [Pri] High Address as soon as possible after BLOCKER issues and removed [Pri] Normal Schedule for the next available opportuinity. labels Jan 28, 2022
@Copons Copons self-assigned this Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] High Address as soon as possible after BLOCKER issues [Type] Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants