Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE: Navigation block has the toolbar on top of the block #64396

Closed
Robertght opened this issue Jun 7, 2022 · 11 comments
Closed

FSE: Navigation block has the toolbar on top of the block #64396

Robertght opened this issue Jun 7, 2022 · 11 comments
Labels
[Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Pri] Normal [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@Robertght
Copy link

Quick summary

Hey!

In FSE, the toolbar covers the block itself, so we cannot select a specific menu or make edits on it.

This happens only in FSE, not in the Pages/Posts editor.

Steps to reproduce

  1. Activate an FSE theme
  2. Go to Appearance > Editor
  3. Add or try to modify an existing navigation block

What you expected to happen

To be able to manage the menu easily

What actually happened

image

Context

Discovered this while testing another PR

Slack ref: p1654278757904299-slack-C01DF571R5Y

cc @Automattic/cylon for further visibility

I couldn't replicate this on self-hosted

Simple, Atomic or both?

Simple, Atomic

Theme-specific issue?

FSE themes

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

All

Available workarounds?

No but the platform is still usable

Workaround details

No response

@Robertght Robertght added [Type] Bug [Pri] High User Report This issue was created following a WordPress customer report [Feature] Full Site Editor The site editor. labels Jun 7, 2022
@Robertght Robertght added the Triaged To be used when issues have been triaged. label Jun 7, 2022
@Robertght
Copy link
Author

Core issue: WordPress/gutenberg#41575

@Addison-Stavlo
Copy link
Contributor

Addison-Stavlo commented Jun 7, 2022

While the original screen capture above shows the toolbar's bottom position conflict with submenu items (as reported in core here WordPress/gutenberg#40382 (comment))

This issue describes a new regression in block toolbar behavior, causing obstruction of any selected block near the top of the editor canvas. I opened a core issue here as well for this regression - WordPress/gutenberg#41575

@ccwalburn
Copy link

Another case reported here: 35430108-hc

@supernovia supernovia added the [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. label Jul 18, 2022
@hacchism
Copy link

Another case: 36124777-hc (the user didn't mention it actually but I noticed it while checking the user's Site Editor)

@khristiansnyder
Copy link

I've noticed this issue for a while and it is making it very difficult to use the block or add a new menu to FSE sites.

@tanjoymor
Copy link

Just to note that the work around for this is to pin the toolbar to the top. Click the 3-dots contextual menu in the top right corner and choose Top Toolbar.

@youbrokesomething
Copy link
Contributor

There have been a couple of improvements to this since Gutenburg v14.0, the latest is in Gutenburg v14.3 and we should retest to see if this is fixed when that's out.

@happychait
Copy link

Stumbled upon this issue while trying to update dotcom sub-menu support guide.

Just want to note for myself, and for posterity, the core issues tracking sub-menu usability issues are the following:

WordPress/gutenberg#40382 linked from this comment: WordPress/gutenberg#36977 (comment)

The Core issue mentioned in the above comment is for the top-level parent menu items, which has since been fixed 🎉

@Greatdane
Copy link

WordPress/gutenberg#41575 has been closed, but it may be getting fixed via WordPress/gutenberg#40382

@cuemarie cuemarie added [Pri] Normal [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. and removed [Pri] High labels Oct 5, 2023
@cuemarie
Copy link

cuemarie commented Oct 5, 2023

📌 ACTIONS

  • Due to the age of this issue, I've downgraded the priority from High to Normal to better reflect its status, as this is primarily waiting on Core fixes, and hasn't caused a ton of support volume while we wait for that update.

@annezazu
Copy link

Closing this out as the original problem was fixed in GB WordPress/gutenberg#40382 with this PR: WordPress/gutenberg#62711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Pri] Normal [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report
Development

No branches or pull requests