-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg - Margin controls on any block that involves layout #64438
Comments
#35897506-hc |
This seems to be similar to this other issue: #62782 As mentioned in the above comment, this also happens with Paragraph blocks, there's a gap on the top when using a paragraph with an image on the left (or on the right), for example: This doesn't happen with older themes. The above was with Twenty Twenty-Two, but it works with Hemingway Rewritten. And the issue is with that same |
One of the interactions about it: 5335066-zd-woothemes, had more in the past |
It looks as though this is related to the @annezazu can you provide any insight to if the issue mentioned here is something being addressed in core? Potentially related issues I see are: |
👋🏼 Hey hey!
This specifically relates to Consistent Dimension controls . Going a step further though, alongside the dimensions, the problem remains that there needs to be an easier way to reset block gap (as you can see discussed in this issue about adding margin support to the group block). Can you all gather a few more examples/share more here @jordesign? From there, I can see about opening an overall adjacent issue to the consistent dimension controls one as adding controls is just one piece of this. |
Some adjacent thinking and exploration surrounding a more complete set of layout tools here |
36074196-hc Workaround - CSS |
@jordesign wanted to loop back on the above examples to see if we had a list of a few (3-4 ideally). No rush! Just looping back. |
@annezazu we might've lost this between the different channels. I've shared a list of my findings regarding similar experiences, but I'd say they don't all share the same factors here: pc4f5j-2dU-p2#comment-2805 Automattic/themes#6197 I'm not quite sure about this either, but looping in @pbking and @jeffikus for a second opinion on this. |
@annezazu - it's been tricky to find interactions around this - as the wording/description of the issue when dealing with users is pretty varied and generic (around gaps between blocks) but anecdotally I know I've run into it... A specific case (from empathy testing) is in the home page of Pe8rBq-2-p2 where there is no way to close the gap between Cover blocks within the Query/Loop of the layout. |
Thank you all for trying to gather more of these! Let's keep this open and see if more items/specific use cases come up for a feedback style issue. For now, there's far more momentum around consistent dimension controls that should help resolve the original issue described here: WordPress/gutenberg#43241 You can see what's planned for margin and blocks specifically here: WordPress/gutenberg#43243 |
Thanks for weighing in on this @annezazu and @jordesign ! Based on the advice above, I'm marking this as triaged to keep open and on our radar for now. Thanks! 📌 ACTIONS
|
User report 5759835-zen |
This issue makes it impossible to create nice site sections with Cover blocks, which is a bummer. I was looking to create a shadow effect using 2 Cover blocks, to have a nice transition between blocks like this (example from a third-party theme not using Gutenberg): Since this result isn't possible to achieve with one Cover block and its Gradient option, using 2 Cover blocks also isn't possible because of this gap issue, since this would be the result: I would expect that adding zero to the blocks' padding would remove that space, but that doesn't happen. |
+1 for adding margin controls on template part blocks too because that would allow us to reset the global block gap as suggested in the issue WordPress/gutenberg#47637. See how the template part block gets the global block gap and cannot be removed because of the lack of margin controls: For context, the padding controls were removed in Remove color, spacing, and layout options for Template Part block. |
What
Blocks like Cover block, Media and text block , do not have the provision to adjust margins ( especially top and bottom margins ) . That leads to awkward white gaps in layouts
Blocks seem to have padding controls, but not margin.
Why
Without this control user has to depend on CSS which defeates the purpose of Gutenberg / FSE making things code free.
context : 35742471-hc
How
Try adding two cover blocks one below other and check the gap between the two.
The text was updated successfully, but these errors were encountered: