Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to core page template modal #77143

Open
simison opened this issue May 19, 2023 · 4 comments
Open

Switch to core page template modal #77143

simison opened this issue May 19, 2023 · 4 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request".

Comments

@simison
Copy link
Member

simison commented May 19, 2023

We built a "new page template" ahead of core, which was good:

Image

Since then, core has been building similar modal over time, but it was still missing categories when I last time checked in Dec 2022 (p58i-dox-p2#comment-56492).

The modal is in active development again and will likely match or pass the UX of our soon:

Image

We should switch to core modal when core modal has categories sidebar.

If other flow improvements from core issue ship first, we should ensure our modal works well with those improvements:

Image

Important to follow up with docs updates.

FYI @autumnfjeld @ianstewart

@richtabor
Copy link

Note that the core implementation does not have categories, it's just a modal. We could push this WordPress/gutenberg#56944 forward on core thought to switch over.

Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • p58i-dox-p2#comment-56492

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Oct 18, 2024
@simison
Copy link
Member Author

simison commented Dec 20, 2024

@scruffian @richtabor the WP.com custom modal could now be removed since sidebar version merged in Gutenberg? WordPress/gutenberg#66836

@richtabor
Copy link

@scruffian @richtabor the WP.com custom modal could now be removed since sidebar version merged in Gutenberg? WordPress/gutenberg#66836

One thing I noted is that the patterns in the dotCom modal are not represented as "Starter Content" in the Inserter.

These dedicated page patterns require the Block Types: core/post-content header passed through.

Example:

/**
 * Title: Portfolio Page
 * Slug: assembler/page-portfolio
 * Categories: page
 * Viewport width: 1400
 * Block Types: core/post-content
 */

The dotCom starter content modal:

Image

I should see a "Starter content" category here:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request".
Projects
None yet
Development

No branches or pull requests

2 participants