-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Starter Content modal with inserter panel #66836
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
5ac83d8
to
2f20ab1
Compare
Playwright test failures look legit. Let's get those fixed up and then we can look to land this one. |
Flaky tests detected in 36a302d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12432233258
|
// This is a temp workaround for dragging and dropping images from the inserter. | ||
// This should be removed when we have the zoom out view for media categories. | ||
await page.setViewportSize( { width: 1400, height: 800 } ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this isn't needed anymore so I went ahead and removed it.
I think I've fixed the failing tests, but would appreciate more eyes on the changes in case I've changed too much! They were either failing because we'd stopped passing the full These tests needed adjusting for the category object:
These tests needed adjusting for the open inserter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last few commits resolved the discussion here about making sure zoom out is still invoked when creating a new page via the command palette. With that, I think this is ready to bring in 🎉
What?
Builds on #66819.
Previously: #61489.
Closes #63865
Why?
The modal is super annoying, let's see if the inserter + zoom out is less annoying. You can double click the canvas to exit also.
A nice side effect is also that you can inserter multiple patterns, or browser other categories.
How?
Uses #61489.
Testing Instructions
Create a new page in the admin or site editor. Click patterns from this category.
Testing Instructions for Keyboard
Screenshots or screencast