-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task: Implement additional Jetpack tests. #80730
Comments
I'll take point on Forms. Asked a question below about designing a potential dedicated E2E spec (as opposed to block smoke test) that focuses on Forms. Let me know what you think! pdWQjU-rL-p2#comment-537 |
After some more designing today, I had the idea to split up up the block smoke testing for forms and the full flow. This means, two specs:
|
⬆️ Sounds good to me. One nitpick suggestion: what if the full spec is named like |
Oh that's fine too! Although, I'm not sure I want to necessarily couple it tightly to a specific type of form, because we might change that based on whatever is easiest --- the focus isn't the form content, but that you can submit forms on webpages and see the responses in Admin! |
Adding some test plan mapping notes / ideas:
This test actually shouldn't be that hard, and would be a good test! We could just...
I added this because I think this is a big money maker for us, and I think any coverage here could be good.
It looks like the simple sites may have a tumblr connection already set up, so we might be able to use that to test a very simple/basic version of this case! |
It looks like we have a tracking pixel and its details are here: p7pQDF-5HJ-p2. Basically, we want to see if the request for a tracking pixel (at @jeherve does the above sound okay? |
Yes, I think checking for the Checking for the |
Edit: I figured it out for AT sites - the tracking pixels don't load if viewing the post as the publishing user, unlike on Simple where it does. Solution is to view the post as a logged out user. Oddly, it seems on the AT blogs the tracking pixel isn't being loaded. These are the only requests I see:
|
Is the Stats module enabled on those sites?
Another option could be to change the Stats options to allow tracking logged in users as well, but that may be more steps. |
Yes, it is enabled. The issue as I found out is a behavior difference between AT and Simple sites.
To clarify, the tracking pixel is being loaded as logged out user on AT and Simple. The only time the tracking pixel isn't loading on AT is when viewing the published post as the publishing user. In any case, we want to view the post not as the publishing user. |
Going to go ahead and close this now, as we are at the end of our window for implementing these test. We've gotten the vast vast vast majority of the items here, and increased the coverage a lot! |
Details
Taking into account outcome for pdWQjU-rL-p2, begin implementing new Jetpack E2E tests from the highest priority & easiest to implement.
Checklist
Task list taken from the Jetpack - Calypso test coverage mapping spreadsheet.
No response
Must Cover Tasks
Important Tasks
The text was updated successfully, but these errors were encountered: