AT: Disable Jetpack and Vaultpress plugin actions #11817

jhnstn · 2017-03-07T06:11:43Z

This hides the plugin actions for Jetpack and Vaultpress on automated transfer sites for the following routes:
http://calypso.localhost:3000/plugins/:site
http://calypso.localhost:3000/plugins/:plugin/:site

`plugins/:site`

The targeted plugins no longer display the activation or auto update toggles. There is also added messaging: {plugin} is automatically managed on this site

`plugins/:plugin/:site`

Users can still click through the plugin in the list to access details page. Here the actions again are not displayed but there is no additional messaging.

The PR does not address bulk changes or non site selected pages ( /plugins or /plugins/:plugin).

The changes here were guided from the feedback in #11541. In particular:

Take a more generalized approach to disabling plugin actions.
Do not grey out or disable clicking through to the detail page.
Consider using server side logic for filtering plugin actions

On the last point this PR does use existing logic in calypso to check for automated transfer sites but the check is done further up the component hierarchy. It should be simple to refactor getAllowedPluginActions and remove the AT site selector after the new attributes are available from the plugins api.

Related PR : #11541
Fixes 84-gh-automated-transfer

@Automattic/stark
cc @johnHackworth @enejb

for jetpack and vaultpress

matticbot · 2017-03-07T06:11:44Z

Test live: https://calypso.live/?branch=add/disable-plugin-actions

retrofox · 2017-03-07T09:26:37Z

client/my-sites/plugins/plugins-list/index.jsx

+	getAllowedPluginActions( ) {
+		return {
+			autoupdate: true,
+			activation: true


Usually, we use trailing comma. Not a big deal, though.

retrofox · 2017-03-07T09:46:54Z

client/my-sites/plugins/plugin-item/plugin-item.jsx

@@ -160,6 +160,15 @@ module.exports = React.createClass( {
 				);
 			}
 		}
+
+		if ( this.props.isAutoManaged ) {


Although this component doesn't have defined rightly any property, I suggest defining isAutoManaged and allowedActions (type and default value) on this patch.

retrofox · 2017-03-07T09:53:07Z

client/my-sites/plugins/plugin-meta/index.jsx

-					notices={ this.props.notices } wporg={ this.props.plugin.wporg } isMock={ this.props.isMock } />
-				<PluginRemoveButton plugin={ this.props.plugin } site={ this.props.selectedSite }
-					notices={ this.props.notices } isMock={ this.props.isMock } />
+				{ canToggleActivation && <PluginActivateToggle plugin={ this.props.plugin } site={ this.props.selectedSite }


These lines are increasing too much. Could we separate the properties a little to improve reading? Something like ...

{ canToggleActivation && <PluginActivateToggle plugin={ this.props.plugin } site={ this.props.selectedSite } notices={ this.props.notices } isMock={ this.props.isMock } /> }

Not a big deal. Feel free to ignore this comment.

retrofox · 2017-03-07T09:54:43Z

client/my-sites/plugins/plugins-list/index.jsx

+		return {
+			selectedSite,
+			selectedSiteSlug: getSelectedSiteSlug( state ),
+			isSiteAutomatedTransfer: isSiteAutomatedTransfer( state, get( selectedSite, 'ID' ) )


missing trailing comma

retrofox · 2017-03-07T10:05:46Z

~~The information about why these features are disabled maybe are too generic.~~

~~We could add more context information in another patch, though.~~

Ignore my comments here. I was taking a look to the wrong place. My bad.

retrofox · 2017-03-07T10:17:37Z

I wonder if have we get rid of apply transparency to the disabled plugins? cc @rralian #11541 (comment)

if not I think they should be applied on this PR.

retrofox · 2017-03-07T10:30:02Z

client/my-sites/plugins/plugin-item/plugin-item.jsx

 		return (
 			<div className="plugin-item__actions">
-				<PluginActivateToggle
+			{ canToggleActivation && <PluginActivateToggle


I wonder if we could hide these components in the same way that they are disabled. Instead of ...

{ canToggleAutoupdate && <PluginAutoupdateToggle isMock={ this.props.isMock } // ... /> } }

... implement something like ...

<PluginAutoupdateToggle isMock={ this.props.isMock } hide={ ! canToggleAutoupdate } // ... />

I think it looks more readable, but I don't wanna bothering you with too many details. Again, feel free to ignore this.

johnHackworth · 2017-03-07T10:32:21Z

Code-wise, looks good

retrofox · 2017-03-07T10:35:36Z

I've tested the implementation, and it looks great. It works like expected.
Beyond some comments that I left, I think it is almost done. Thanks, @jhnstn for this PR. Let's wait for other 👀.

enejb · 2017-03-07T16:41:55Z

Lets also update the README.md files if we are updating the props.

For example https://github.com/Automattic/wp-calypso/blob/master/client/my-sites/plugins/plugins-list/README.md

gwwar · 2017-03-08T19:09:30Z

We can follow up on this in other PRs, but I think we should add some similar this is managed messaging on plugins/:plugin/:site

We also confusingly show the installation tab

gwwar · 2017-03-08T19:33:39Z

If folks are happy with changes here, let's 🚢 this and follow up in additional PRs. Since this is a larger changeset let's take care to test main flows on stage in addition to the plugin changes here.

rralian · 2017-03-10T14:58:02Z

Good job! This looks and works great for me, so I say . I don't have a strong feeling about removing the "Installation" tab from the plugin info. I agree that we could remove the "installation" tab for installed plugins, but that's a Jetpack issue, not an Automated Transfer issue. I added a separate issue to ask the question for Jetpack in general. #12008

jhnstn added 6 commits March 6, 2017 10:38

add ability to hide plugin actions

ed85649

hide plugin update/activate toggles for AT sites

b6d1418

add ability to hide plugin actions on plugin page

3cb9886

hide plugin actions on AT plugin pages

f5077ee

for jetpack and vaultpress

clean up conditional with _.includes

2d35622

clean up getAllowedPluginActions

0804838

matticbot added the [Size] L Large sized issue label Mar 7, 2017

jhnstn requested review from retrofox, gwwar, artpi and lamosty March 7, 2017 06:12

jhnstn added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 7, 2017

jhnstn requested a review from rralian March 7, 2017 06:13

jhnstn added the [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. label Mar 7, 2017

retrofox reviewed Mar 7, 2017

View reviewed changes

cleanup and add trailing comma

39fa617

matticbot added the [Size] L Large sized issue label Mar 7, 2017

jhnstn added 2 commits March 7, 2017 14:00

add prop types to plugin item

04cf07a

update component readme's

a3d41ee

gwwar approved these changes Mar 8, 2017

View reviewed changes

rralian approved these changes Mar 10, 2017

View reviewed changes

rralian added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 10, 2017

jhnstn merged commit 56cce55 into master Mar 13, 2017

jhnstn deleted the add/disable-plugin-actions branch March 13, 2017 16:54

matticbot removed the [Status] Ready to Merge label Mar 13, 2017

snyk-bot mentioned this pull request May 30, 2021

[Snyk] Fix for 1 vulnerabilities ajesse11x/wp-calypso#52

Open

snyk-bot mentioned this pull request Oct 25, 2021

[Snyk] Fix for 1 vulnerabilities ajesse11x/wp-calypso#65

Open

snyk-bot mentioned this pull request Nov 4, 2021

[Snyk] Fix for 1 vulnerabilities ajesse11x/wp-calypso#66

Open

ajesse11x mentioned this pull request Oct 20, 2023

[Snyk] Fix for 2 vulnerabilities ajesse11x/wp-calypso#93

Open

ajesse11x mentioned this pull request Nov 16, 2023

[Snyk] Fix for 2 vulnerabilities ajesse11x/wp-calypso#95

Open

ajesse11x mentioned this pull request Mar 28, 2024

[Snyk] Fix for 2 vulnerabilities ajesse11x/wp-calypso#102

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AT: Disable Jetpack and Vaultpress plugin actions #11817

AT: Disable Jetpack and Vaultpress plugin actions #11817

jhnstn commented Mar 7, 2017

matticbot commented Mar 7, 2017

retrofox Mar 7, 2017

retrofox Mar 7, 2017

jhnstn Mar 7, 2017

retrofox Mar 7, 2017

retrofox Mar 7, 2017

retrofox commented Mar 7, 2017 •

edited

Loading

retrofox commented Mar 7, 2017

retrofox Mar 7, 2017

johnHackworth commented Mar 7, 2017

retrofox commented Mar 7, 2017

enejb commented Mar 7, 2017

gwwar commented Mar 8, 2017

gwwar commented Mar 8, 2017

rralian commented Mar 10, 2017

AT: Disable Jetpack and Vaultpress plugin actions #11817

AT: Disable Jetpack and Vaultpress plugin actions #11817

Conversation

jhnstn commented Mar 7, 2017

plugins/:site

plugins/:plugin/:site

matticbot commented Mar 7, 2017

retrofox Mar 7, 2017

Choose a reason for hiding this comment

retrofox Mar 7, 2017

Choose a reason for hiding this comment

jhnstn Mar 7, 2017

Choose a reason for hiding this comment

retrofox Mar 7, 2017

Choose a reason for hiding this comment

retrofox Mar 7, 2017

Choose a reason for hiding this comment

retrofox commented Mar 7, 2017 • edited Loading

retrofox commented Mar 7, 2017

retrofox Mar 7, 2017

Choose a reason for hiding this comment

johnHackworth commented Mar 7, 2017

retrofox commented Mar 7, 2017

enejb commented Mar 7, 2017

gwwar commented Mar 8, 2017

gwwar commented Mar 8, 2017

rralian commented Mar 10, 2017

`plugins/:site`

`plugins/:plugin/:site`

retrofox commented Mar 7, 2017 •

edited

Loading