-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans: First pass at adding ProgressBar to PlanThankYouCard for Jetpack sites #11927
Conversation
1a96a8a
to
4829dd1
Compare
Here are some screenshots of how the Note: These are not all personal plans. I manually changed the plan slug to test out the color schemes. Green would be premium and purple would be business. Here's a demo video of the ProgressBar in action: |
I tweaked the ProgressBar colors after some feedback from @rickybanister in Slack. Here are updated screenshots. |
That looks perfect @ebinnion! You're too fast. |
This is great! Well done y'all! |
@@ -50,6 +58,7 @@ const PlanThankYouCard = ( { | |||
buttonUrl={ siteUrl } | |||
buttonText={ translate( 'Visit Your Site' ) } | |||
icon={ planIcon } | |||
action={ renderAction() } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldn't this be just action={ action }
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in this case. renderAction
is a reference to a function, and we need to invoke it.
nice work! |
This PR is meant to add a colorized
ProgressBar
to theJetpackThankYouCard
component. It relies on #11865 being merged first.You can view @rickybanister's mocks for colorized thank you pages here: p6TEKc-105-p2
Screenshots will come after I merge the other PR.Screenshots below.cc @lezama @enejb for code review.
To test: