Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans: First pass at adding ProgressBar to PlanThankYouCard for Jetpack sites #11927

Merged
merged 5 commits into from
Mar 9, 2017

Conversation

ebinnion
Copy link
Contributor

@ebinnion ebinnion commented Mar 8, 2017

This PR is meant to add a colorized ProgressBar to the JetpackThankYouCard component. It relies on #11865 being merged first.

You can view @rickybanister's mocks for colorized thank you pages here: p6TEKc-105-p2

Screenshots will come after I merge the other PR. Screenshots below.

cc @lezama @enejb for code review.

To test:

@ebinnion ebinnion added .org Plans Components [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Status] In Progress labels Mar 8, 2017
@ebinnion ebinnion self-assigned this Mar 8, 2017
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Size] L Large sized issue label Mar 8, 2017
@ebinnion ebinnion force-pushed the update/progress-bar-plan-colors branch from 1a96a8a to 4829dd1 Compare March 9, 2017 15:47
@matticbot matticbot added the [Size] L Large sized issue label Mar 9, 2017
@matticbot matticbot added [Size] XL Probably needs to be broken down into multiple smaller issues and removed [Size] L Large sized issue labels Mar 9, 2017
@ebinnion
Copy link
Contributor Author

ebinnion commented Mar 9, 2017

Here are some screenshots of how the ProgressBar looks when integrated into the colorized plan cards:

Note: These are not all personal plans. I manually changed the plan slug to test out the color schemes. Green would be premium and purple would be business.

screen shot 2017-03-09 at 10 00 30 am
screen shot 2017-03-09 at 10 01 17 am
screen shot 2017-03-09 at 10 01 59 am

Here's a demo video of the ProgressBar in action:

progress-bar-demo

@matticbot matticbot added [Size] L Large sized issue and removed [Size] XL Probably needs to be broken down into multiple smaller issues labels Mar 9, 2017
@ebinnion
Copy link
Contributor Author

ebinnion commented Mar 9, 2017

Here's a video after fixing the logic for generating how much progress has been made. Notice that the progress actually starts at 0 now.

progress-bar-better-logic

@ebinnion ebinnion added the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Mar 9, 2017
@ebinnion
Copy link
Contributor Author

ebinnion commented Mar 9, 2017

I tested the new WPCOM user flow for regressions, and all looks well. 👍

screen shot 2017-03-09 at 10 53 18 am
screen shot 2017-03-09 at 10 53 35 am
screen shot 2017-03-09 at 10 53 52 am

@ebinnion ebinnion added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Mar 9, 2017
@matticbot matticbot added the [Size] L Large sized issue label Mar 9, 2017
@ebinnion
Copy link
Contributor Author

ebinnion commented Mar 9, 2017

I tweaked the ProgressBar colors after some feedback from @rickybanister in Slack. Here are updated screenshots.

screen shot 2017-03-09 at 11 06 04 am
screen shot 2017-03-09 at 11 05 15 am
screen shot 2017-03-09 at 11 02 19 am

@rickybanister
Copy link

That looks perfect @ebinnion! You're too fast.

@rickybanister rickybanister removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Mar 9, 2017
@folletto
Copy link
Contributor

folletto commented Mar 9, 2017

This is great! Well done y'all!

@@ -50,6 +58,7 @@ const PlanThankYouCard = ( {
buttonUrl={ siteUrl }
buttonText={ translate( 'Visit Your Site' ) }
icon={ planIcon }
action={ renderAction() }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't this be just action={ action }?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in this case. renderAction is a reference to a function, and we need to invoke it.

@lezama lezama added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 9, 2017
@lezama
Copy link
Contributor

lezama commented Mar 9, 2017

nice work!

@ebinnion ebinnion merged commit e067ed0 into master Mar 9, 2017
@ebinnion ebinnion deleted the update/progress-bar-plan-colors branch March 9, 2017 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Components [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Size] L Large sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants